Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI inputs: Fix typings #800

Merged
merged 4 commits into from
Feb 22, 2024
Merged

UI inputs: Fix typings #800

merged 4 commits into from
Feb 22, 2024

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Feb 21, 2024

This PR fixes some typings in the dropdown-multiselect.component and filter-dropdown.component that cause issues when reusing and extending these components in a different project.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by MEL.

Comment on lines 180 to 184
select(choice: Choice, checked: boolean | Event) {
const selected =
checked instanceof Event
? (checked.target as HTMLInputElement).checked
: checked
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't like this but couldn't find a better solution.

Copy link
Contributor

github-actions bot commented Feb 21, 2024

Affected libs: feature-search, feature-router, feature-map, feature-dataviz, feature-record, ui-inputs, feature-editor, ui-elements, feature-catalog, ui-catalog, ui-search,
Affected apps: metadata-editor, datahub, demo, webcomponents, search, map-viewer, metadata-converter, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@tkohr tkohr changed the title DropdownMultiselectComponent: Fix typings UI inputs: Fix typings Feb 21, 2024
@coveralls
Copy link

Coverage Status

coverage: 82.132% (-1.8%) from 83.944%
when pulling 2ecc94d on dropdown-types
into ca02804 on main.

that cause issue when reusing/extending the components
Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworked in pair programming!

@tkohr
Copy link
Collaborator Author

tkohr commented Feb 22, 2024

Thanks for the help finding a better solution @jahow !

@tkohr tkohr merged commit 7a59af6 into main Feb 22, 2024
9 checks passed
@tkohr tkohr deleted the dropdown-types branch February 22, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants