Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datahub][API form] Empty string not read as negative limit #815

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Mar 6, 2024

Description

This PR fixes that empty strings are interpreted as -1 for the limit input.
It also updates the docker compo with a new dump, which changes a deprecated OGC API URL to a working one.

Please run docker-compose down -v and docker-compose up -d to have the right dump.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Mar 6, 2024

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: metadata-editor, datahub, demo, webcomponents, map-viewer, search,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Mar 6, 2024

Coverage Status

coverage: 86.195% (+0.01%) from 86.184%
when pulling 3da2a77 on fix/ogc-request-limit
into 4db0b59 on main.

Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @cmoinier ! It works fine now. I left one comment regarding the template. Maybe we could also leverage this PR to resolve the typing issues we had in MEL and apply the same changes here.

Copy link
Collaborator

@tkohr tkohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adaptions @cmoinier !

@cmoinier cmoinier merged commit cbcafed into main Mar 7, 2024
9 checks passed
@cmoinier cmoinier deleted the fix/ogc-request-limit branch March 7, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants