Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datahub] Updated styling for the navigation-button and language-switcher #823

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

ronitjadhav
Copy link
Collaborator

@ronitjadhav ronitjadhav commented Mar 15, 2024

Description

This PR updates the styling for the navigation button (back button) and language switcher, which fixes the issue of text not being visible when the background is white.

  • Updated style of navigation button to use the colour from the "header_foreground_color" setting from the config.
  • Update style for the language switcher text
  • All text in the header should be the same colour and that color should be the header_foreground_color setting from the config

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by Organization ABC.

Copy link
Contributor

github-actions bot commented Mar 15, 2024

Affected libs: ui-catalog, feature-catalog, feature-record, feature-router, ui-inputs, feature-dataviz, feature-search, feature-map, feature-editor, ui-elements, ui-search, ui-layout,
Affected apps: datahub, metadata-editor, demo, webcomponents, map-viewer, search, metadata-converter, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Mar 15, 2024

Coverage Status

coverage: 82.262% (-1.0%) from 83.263%
when pulling 392a352 on fix-text-not-visible
into 5042be2 on main.

@ronitjadhav ronitjadhav merged commit 463b60b into main Mar 19, 2024
9 checks passed
@ronitjadhav ronitjadhav deleted the fix-text-not-visible branch March 19, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants