Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slight gradient to "show more" block #837

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

jahow
Copy link
Collaborator

@jahow jahow commented Mar 25, 2024

Description

This PR improves the "show more" component (gn-ui-max-lines) visually by adding a gradient on top:

Also fixes a layout issue within the Datahub if the data producer has no logo.

Architectural changes

none

Screenshots

image

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

This work is sponsored by Swisstopo.

Copy link
Contributor

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: metadata-editor, datahub, demo, webcomponents, map-viewer, search,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 86.136% (-0.2%) from 86.337%
when pulling d64f956 on add-show-more-gradient
into 7639a97 on main.

Copy link
Contributor

📷 Screenshots are here!

@ronitjadhav
Copy link
Collaborator

@jahow Tested the changes and everything works as expected.

@jahow jahow merged commit b0f82ed into main Mar 25, 2024
9 checks passed
@jahow jahow deleted the add-show-more-gradient branch March 25, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants