Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM package: Allow router.config to be used in extended router services #845

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Apr 8, 2024

Description

This PR should allow reusing the router.config within a router service extended from the RouterService making it protected and should add the router.config to the exports for the npm package.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Affected libs: feature-router,
Affected apps: metadata-editor, datahub, demo,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

Coverage Status

coverage: 86.602% (+4.1%) from 82.511%
when pulling cc178f7 on npm-router-service
into e441b92 on main.

Copy link
Contributor

github-actions bot commented Apr 8, 2024

📷 Screenshots are here!

@tkohr tkohr merged commit 1b3d989 into main Apr 9, 2024
9 checks passed
@tkohr tkohr deleted the npm-router-service branch April 9, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants