-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a DCAT-AP converter using RDF #932
Conversation
Affected libs:
|
📷 Screenshots are here! |
48b7000
to
9d6c6b0
Compare
9d6c6b0
to
eb52d47
Compare
e4a4a30
to
a1aaa4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the big work @jahow ! Code LGTM as far as I can see.
When doing some quick testing with https://github.com/w3c/dxwg/blob/gh-pages/dcat/examples/basic-example.jsonld or ttl in the converter app I get errors when I switch to the ISO formats.
Error for ttl
: Failed: Could not determine role code from role: pointOfContact
Error for jsonId
: Failed: Invalid time value
@@ -11,7 +11,7 @@ <h1 class="text-[50px] font-bold font-title my-6 mx-10"> | |||
></gn-ui-status> | |||
</h1> | |||
</div> | |||
<div class="grow p-3"> | |||
<div class="grow shrink-0 p-3 min-w-[50%]"> | |||
<input | |||
type="file" | |||
accept=".xml, application/xml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably add jsonId
and ttl
here now.
Thank you for trying things out! I'll look into it |
Writing is mostly not implemented for now
Otherwise the operation will be largely destructive & not keep the initial schema
…ibility The output should work for the DCAT-AP plugin
a1aaa4b
to
fdde3bb
Compare
@tkohr I've addressed your comments, some mandatory fields of a record were indeed not filled with the DCAT-AP converter. I also tweaked the DCAT output so that it can sort of work with the GN DCAT-AP plugin :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the conversion of the jsonld
file above now works in the converter. Still getting an error for the same example in ttl
though: status.component.ts:90 TypeError: Cannot read properties of undefined (reading 'name') at write-parts.ts:222:39
. Watch out the CI also turned red.
fdde3bb
to
52ff35b
Compare
52ff35b
to
d8df3f0
Compare
e2483d3
to
4219ecc
Compare
Description
This PR introduces a new metadata converter for the DCAT-AP profile. The Metadata Converter app has been modified to allow handling this new format.
Limitations:
reading is limited to certain fields of the model (i.e. no extents, no licence/constraints, etc.)Note that the converter can handle either RDF/XML, JSON-LD or Turtle (both for input and output).
This also fixes a bug where the original XML of a record was lost when it was modified and saved!
Architectural changes
Added DcatApConverter class in libs/api/metadata-converter
Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label