Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create api card and form to request Ign download api #989

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mmohadIGN
Copy link

@mmohadIGN mmohadIGN commented Sep 11, 2024

Description

This PR introduces a new component designed to create an API card for requesting the IGN download API. The component simplifies the integration process by providing a form to interact with the IGN download API.

Architectural changes

Screenshots

image

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Details issues #766

@jahow
Copy link
Collaborator

jahow commented Sep 18, 2024

Hi @mmohadIGN, sorry for the late reply but the team is currently busy working on a first version of the Metadata Editor app, so we simply don't have the bandwidth to look into this PR. Is this OK if the review happens later in October? Thanks

@mmohadIGN
Copy link
Author

Hi @mmohadIGN, sorry for the late reply but the team is currently busy working on a first version of the Metadata Editor app, so we simply don't have the bandwidth to look into this PR. Is this OK if the review happens later in October? Thanks

Hi @jahow, it's fine, no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants