Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ME: Add separate search state for myRecords #997

Conversation

tkohr
Copy link
Collaborator

@tkohr tkohr commented Sep 20, 2024

Description

This PR adds a separate search state for myRecords. This allows paginating, sorting and filtering independently on MyRecords and AllRecords.

  • The myRecords state is currently not bound to the URL.
  • There is currently only one search input that is bound to the main search

Note: There is one strange behavior occurring in components used within the myRecords state. The async pipe does not update when setting a component observable with a SearchFacade observable. Using the SearchFacade's observable directly in the async pipe or subscribing to it works fine.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

Copy link
Contributor

github-actions bot commented Sep 20, 2024

Affected libs: feature-editor, feature-search, feature-router, feature-map, feature-dataviz, feature-record, ui-inputs, ui-elements, feature-notifications, feature-catalog, ui-catalog, ui-search, ui-layout,
Affected apps: metadata-editor, datafeeder, demo, datahub, webcomponents, search, map-viewer, metadata-converter,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@rcaplier rcaplier force-pushed the me-fix-misc-issues-with-dashboard-views branch from 165a572 to 00a0004 Compare September 20, 2024 13:48
@tkohr tkohr force-pushed the me-fix-misc-issues-with-dashboard-views-myrecord-state-rebased branch from e8da379 to 3b8a016 Compare September 20, 2024 13:49
@rcaplier rcaplier force-pushed the me-fix-misc-issues-with-dashboard-views branch from 00a0004 to ba93874 Compare September 20, 2024 13:53
Copy link
Contributor

github-actions bot commented Sep 20, 2024

📷 Screenshots are here!

@rcaplier rcaplier force-pushed the me-fix-misc-issues-with-dashboard-views branch from ba93874 to a98e713 Compare September 20, 2024 14:06
@tkohr tkohr force-pushed the me-fix-misc-issues-with-dashboard-views-myrecord-state-rebased branch from 3b8a016 to 95e149d Compare September 20, 2024 14:25
Copy link
Collaborator

@rcaplier rcaplier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@tkohr tkohr force-pushed the me-fix-misc-issues-with-dashboard-views-myrecord-state-rebased branch from b625cdf to 8995729 Compare September 23, 2024 09:05
@tkohr tkohr merged commit 8e35f64 into me-fix-misc-issues-with-dashboard-views Sep 23, 2024
13 checks passed
@tkohr tkohr deleted the me-fix-misc-issues-with-dashboard-views-myrecord-state-rebased branch September 23, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants