-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ME: Add separate search state for myRecords #997
ME: Add separate search state for myRecords #997
Conversation
Affected libs:
|
165a572
to
00a0004
Compare
e8da379
to
3b8a016
Compare
00a0004
to
ba93874
Compare
📷 Screenshots are here! |
ba93874
to
a98e713
Compare
3b8a016
to
95e149d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
b625cdf
to
8995729
Compare
8e35f64
into
me-fix-misc-issues-with-dashboard-views
Description
This PR adds a separate search state for
myRecords
. This allows paginating, sorting and filtering independently onMyRecords
andAllRecords
.myRecords
state is currently not bound to the URL.Note: There is one strange behavior occurring in components used within the
myRecords
state. The async pipe does not update when setting a component observable with aSearchFacade
observable. Using theSearchFacade
's observable directly in the async pipe or subscribing to it works fine.Quality Assurance Checklist
breaking change
labelbackport <release branch>
label