Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] allow to open COG links in external viewer (#7387) #286

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

landryb
Copy link
Member

@landryb landryb commented Jan 26, 2024

  • add OGC:COG to possible values for gmd:protocol

  • add support to open OGC:COG links in the external viewer

  • show an alert saying COG/3DTiles is not supported yet

This will also avoid switching to the viewer if no layer with supported protocol is found


Geochestra/geonetwork checklist

supersedes #252 which targeted a removed branch, and for some reason it seems one can't edit a target branch anymore in existing PRs

* add OGC:COG to possible values for gmd:protocol

* add support to open OGC:COG links in the external viewer

* show an alert saying COG/3DTiles is not supported yet

This will also avoid switching to the viewer if no layer with supported
protocol is found

---------

Co-authored-by: Olivia <olivia.guyot@camptocamp.com>
@landryb landryb requested a review from f-necas January 26, 2024 10:20
@landryb landryb self-assigned this Jan 26, 2024
Copy link
Collaborator

@f-necas f-necas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the losing/forgetting the PR. Can you just document georchestra-migrations to add COG next to 3DTiles and ogc api features ? As we don't move to 4.4.1 by now and 4.2.8 is coming, it may be nice to not forget it
Thanks !

@landryb
Copy link
Member Author

landryb commented Jan 26, 2024

done :)

@f-necas
Copy link
Collaborator

f-necas commented Jan 26, 2024

LGTM, thanks @landryb !

@landryb landryb merged commit baf7ef4 into georchestra:georchestra-gn4.2.x Jan 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants