Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get header url and height from geOrchestra datadir #79

Merged
merged 2 commits into from
Jul 9, 2018

Conversation

Vampouille
Copy link
Contributor

It uses:

  • headerUrl
  • headerHeight
    properties from default.properties or geonetwork/geonetwork.properties
    from geOrchestra datadir

It uses:
* headerUrl
* headerHeight
properties from default.properties or geonetwork/geonetwork.properties
from geOrchestra datadir
@Vampouille Vampouille requested a review from pmauduit July 2, 2018 18:10
@Vampouille
Copy link
Contributor Author

Runtime tested with :

  • values in default.properties
  • values in geonetwork/geonetwork.properties and default.properties
  • no values

Value tested :

  • headerUrl
  • headerHeight

if (globalDatadirPath != null) {
File defaultConfiguration = new File(String.format("%s%s%s", globalDatadirPath,
File.separator, "default.properties"));
File geoserverConfiguration = new File(String.format("%s%s%s%s%s", globalDatadirPath,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

geonetworkConfiguration

@fvanderbiest fvanderbiest merged commit a960992 into georchestra-gn3.4-master Jul 9, 2018
@fvanderbiest fvanderbiest deleted the factorize_header_url branch July 9, 2018 12:27
cmangeat added a commit that referenced this pull request Sep 9, 2019
f-necas pushed a commit that referenced this pull request Nov 14, 2023
* Static pages / Fix links to load html pages content.

Initialise gnActiveTbItem directive with pageId, page.pageId is not yet available when the directive is initialised.

* Pages / Ensure page is initialized before creating active-tb-item (#79)

* Pages / Ensure page is initialized before creating active-tb-item

* Pages / Add more doc about ui config

---------

Co-authored-by: François Prunayre <fx.prunayre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants