Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure subpackages are included in wheel #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make sure subpackages are included in wheel #88

wants to merge 1 commit into from

Conversation

apeschar
Copy link

@apeschar apeschar commented Nov 4, 2022

With the current setup.cfg, a build done using pip wheel does not actually include the core/ and utils/ directories, and when installed, the package is broken.

To test, try this:

rm -rf dist
pip wheel . --no-deps -w dist
unzip -l dist/*.whl

Before this PR:

Archive:  dist/django_cryptography-2.0-py2.py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
      114  11-04-2022 07:52   django_cryptography/__init__.py
     1184  11-04-2022 07:52   django_cryptography/conf.py
     7903  11-04-2022 07:52   django_cryptography/fields.py
        0  11-04-2022 07:52   django_cryptography/py.typed
     1109  11-04-2022 07:52   django_cryptography/typing.py
     1492  11-04-2022 07:56   django_cryptography-2.0.dist-info/LICENSE
     3434  11-04-2022 07:56   django_cryptography-2.0.dist-info/METADATA
      110  11-04-2022 07:56   django_cryptography-2.0.dist-info/WHEEL
       20  11-04-2022 07:56   django_cryptography-2.0.dist-info/top_level.txt
      862  11-04-2022 07:56   django_cryptography-2.0.dist-info/RECORD
---------                     -------
    16228                     10 files

After this PR:

Archive:  dist/django_cryptography-2.0-py2.py3-none-any.whl
  Length      Date    Time    Name
---------  ---------- -----   ----
      114  11-04-2022 07:52   django_cryptography/__init__.py
     1184  11-04-2022 07:52   django_cryptography/conf.py
     7903  11-04-2022 07:52   django_cryptography/fields.py
        0  11-04-2022 07:52   django_cryptography/py.typed
     1109  11-04-2022 07:52   django_cryptography/typing.py
        0  11-04-2022 07:39   django_cryptography/core/__init__.py
    10363  11-04-2022 07:52   django_cryptography/core/signing.py
        0  11-04-2022 07:39   django_cryptography/utils/__init__.py
     6966  11-04-2022 07:52   django_cryptography/utils/crypto.py
     1492  11-04-2022 07:56   django_cryptography-2.0.dist-info/LICENSE
     3434  11-04-2022 07:56   django_cryptography-2.0.dist-info/METADATA
      110  11-04-2022 07:56   django_cryptography-2.0.dist-info/WHEEL
       20  11-04-2022 07:56   django_cryptography-2.0.dist-info/top_level.txt
     1228  11-04-2022 07:56   django_cryptography-2.0.dist-info/RECORD
---------                     -------
    33923                     14 files

@SuperSandro2000 SuperSandro2000 mentioned this pull request May 8, 2023
Merged
12 tasks
@centromere
Copy link

@georgemarshall, would you be willing to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apeschar @centromere