Add folder/package.json entrypoints #178
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Their issue wasn’t resolved with it but it’s here if anyone else finds
issues. Going to hold off since it does a bunch of things that aren’t
observable / hard to catch bugs before shipping / doesn’t npm pack as the
same
…On Wed, Jul 17, 2024 at 2:38 PM Tom Ballinger ***@***.***> wrote:
***@***.**** commented on this pull request.
That's slick! If it works out I'm interested in copying it everywhere that
needs it, curious to hear if it helps
—
Reply to this email directly, view it on GitHub
<#178 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACZQW7QYLNYO7NNLXYUO23ZM3P6BAVCNFSM6AAAAABLBMCQ3OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOBUGEZDSOJYGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of shipping ts next to js, we can make entrypoints folders with a package.json that points to the dist directory.
This was annoying to set up, but happy they only exist when code is being pushed.
If this doesn't solve this issue on Discord then it's probably not worth the breaking change?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.