fix value serde in patch
, comparison of complex values
#22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch
andreplace
were not usingjsonToConvex
, so if you diddb.patch(id, { foo: BigInt(1) })
and thendb.get(id)
it would throw an error because of the field name "$integer".also fixes a bug i recently caused where
db.patch(id, { foo: null })
would throw an error; whoops.fix comparisons for complex values like
BigInt
and arrays, which weren't working, by copying the compare.ts function from the aggregate component. that library isn't perfect, for example i think it considers -0 and +0 to be equal, but it's better than the existingcompareValues
function which thinks["a"] < ["a"]
and{a:null} < {a: null}
added a test that covers all of the operations for all kinds of values.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.