Remove parameter re-assingment

Signed-off-by: Zabil Cheriya Maliackal <zabilcm@gmail.com>
getgauge · Jul 31, 2024 · 25a6914 · 25a6914
1 parent 3f3f264
commit 25a6914
Showing 1 changed file with 17 additions and 14 deletions.
diff --git a/lib/actions/click.js b/lib/actions/click.js
@@ -49,42 +49,45 @@ async function simulateInputEvents(options) {
 }
 
 async function click(selector, options = {}, ...args) {
+  let allOptions = options;
   if (options instanceof RelativeSearchElement) {
-    args = [options].concat(args);
-    options = {};
+    allOptions = [options].concat(args);
   }
-  options = setClickOptions(options);
-  options.noOfClicks = options.clickCount || 1;
+  const clickOptions = setClickOptions(allOptions);
+  clickOptions.noOfClicks = clickOptions.clickCount || 1;
 
   if (isSelector(selector) || isString(selector) || isElement(selector)) {
     const elementActionabilityChecks = [checksMap.covered];
 
     const element = await waitAndGetActionableElement(
       selector,
-      options.force,
+      clickOptions.force,
       elementActionabilityChecks,
-      args,
+      allOptions,
     );
     await checkIfFileType(element);
 
     const { x, y } = await domHandler.boundingBox(
-      options.position,
+      clickOptions.position,
       element.get(),
     );
 
-    options.x = x;
-    options.y = y;
+    clickOptions.x = x;
+    clickOptions.y = y;
 
     if (defaultConfig.headful) {
       await highlightElement(element);
     }
 
-    await simulateInputEvents(options);
-    return `Clicked ${description(selector, true)} ${options.noOfClicks} times`;
+    await simulateInputEvents(clickOptions);
+    return `Clicked ${description(selector, true)} ${clickOptions.noOfClicks} times`;
   }
-  (options.x = selector.x), (options.y = selector.y);
-  await simulateInputEvents(options);
-  return `Clicked ${options.noOfClicks} times on coordinates x : ${selector.x} and y : ${selector.y}`;
+
+  clickOptions.x = selector.x;
+  clickOptions.y = selector.y;
+
+  await simulateInputEvents(clickOptions);
+  return `Clicked ${clickOptions.noOfClicks} times on coordinates x : ${selector.x} and y : ${selector.y}`;
 }
 
 module.exports = { click };