Add rel='nofollow' to all external hardcoded links in templates #3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a general practice, I think it's a good idea to always specify the “why” — the motivation behind the proposed changes — in the commit body/description. That way folks can better understand the rationale, without having to take guesses as to the proponent's state of mind. 😉 I can take a guess as to why, but in the interest of clarity, would you amend the commit body and the PR description here with your thoughts regarding the motivation/rationale? |
Fix getpelican#2956: the HTML tag (eg `<a href="https://getpelican.com">`) in our templates negatively impacts a Pelican-generated site's ranking for Search Engine Optimisation purposes. This can be solved by adding the Google-developed `rel="nofollow"` attribute to external links so that the website's owner does not have to provide link authority to the target. This change also had to be reflected in the tests so that they would pass.
willthong
force-pushed
the
seo-friendly-backlinks
branch
from
7afb72d
to
0e0c22e
Compare
avaris
approved these changes
Oct 28, 2023
justinmayer
approved these changes
Oct 28, 2023
There was a problem hiding this comment.
Many thanks to @willthong for the enhancement and to @avaris for reviewing. 🥇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Resolves: #2956
The HTML tag (eg
<a href="https://getpelican.com">) in our templates negatively impacts a Pelican-generated site's ranking for Search Engine Optimisation purposes. This can be solved by adding the Google-developedrel="nofollow"attribute to external links so that the website's owner does not have to provide link authority to the target. This change also had to be reflected in the tests so that they would pass.