Replace pytz dependency in tests
#3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willthong
force-pushed
the
replace-pytz-in-tests
branch
from
388866f
to
e6248ce
Compare
External dependency `pytz` has already been removed from the main code, but this PR also removes it from the tests. Why have I changed the test timezone from CET to Europe/London? The tests were written with the [W3 examples](http://www.w3.org/TR/NOTE-datetime) in mind, but not accounting for the summertime offset. As such, they originally assumed that datetime(year=1997, month=7, day=16, hour=19, minute=20, tzinfo=ZoneInfo("CET")) would evaluate to 1997-07-16T19:20+01:00. But it doesn't; in summertime (July), CET is actually +02:00 and an example of a +01:00 timezone would be "Europe/London". With the shift to the built in ZoneInfo module, the test therefore needs to be adapted.
willthong
force-pushed
the
replace-pytz-in-tests
branch
from
e6248ce
to
5304348
Compare
justinmayer
approved these changes
Aug 15, 2023
There was a problem hiding this comment.
Many thanks to @willthong for the test enhancement and to @avaris for the review. 💯
justinmayer
changed the title
pytz dependency in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Resolves: #2958 (something like a further resolution because it now includes a resolution within the tests)
External dependency
pytzhas already been removed from the main code, but this PR also removes it from the tests.Why have I changed the test timezone from CET to Europe/London? The tests were written with the W3 examples in mind, but not accounting for the summertime offset. As such, they originally assumed that datetime(year=1997, month=7, day=16, hour=19, minute=20, tzinfo=ZoneInfo("CET")) would evaluate to 1997-07-16T19:20+01:00. But it doesn't; in summertime (July), CET is actually +02:00 and an example of a +01:00 timezone would be "Europe/London". With the shift to the built in ZoneInfo module, the test therefore needs to be adapted.