Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run 'Deploy' action on main repository #3200

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

lioman
Copy link
Contributor

@lioman lioman commented Oct 4, 2023

Deploy action will always fail on forks as the token is not there, this happens on the fork especially, when you are syncing with, main one. This will improve the setup for collaborators.

Deploy action will always fail on forks as the token is not there.
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement, @lioman. I wish it were possible to globally disable a GitHub Action job from running on any fork without having to specify the origin org+repository name explicitly, but that doesn't seem possible. There is a pre-existing discussion thread about precisely that topic, to which I posted a comment with my own suggestions.

For now, I think explicitly naming "getpelican/pelican", as is done here, is the only way to do it, so we might as well use that method until a better solution comes along.

@lioman
Copy link
Contributor Author

lioman commented Oct 4, 2023

Just researched it, and I was kind of surprised, that there is no easier/cleaner solution then this.

@justinmayer justinmayer merged commit 0282c1d into getpelican:master Oct 24, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants