Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a task test-coverage to generate a coverage report #3225

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Add a task test-coverage to generate a coverage report #3225

merged 1 commit into from
Oct 28, 2023

Conversation

boxydog
Copy link
Contributor

@boxydog boxydog commented Oct 28, 2023

Pull Request Checklist

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

justinmayer
justinmayer requested changes Oct 28, 2023
View reviewed changes
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @boxydog! I made a few corrections and a suggestion.

docs/contribute.rst Outdated Show resolved Hide resolved
tasks.py Outdated Show resolved Hide resolved
justinmayer
justinmayer reviewed Oct 28, 2023
View reviewed changes
tasks.py Outdated Show resolved Hide resolved
@boxydog
Add a "coverage" task to generate a coverage report
3a6ae72 
Add a one-liner about "invoke" in docs.
justinmayer
justinmayer approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, @boxydog! ✨

@justinmayer justinmayer merged commit fec78eb into getpelican:master Oct 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmayer justinmayer justinmayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@boxydog @justinmayer