Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Pygments to 2.16.1 in test requirements; fixes #3385 #3386

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

egberts
Copy link
Contributor

@egberts egberts commented Jul 29, 2024

Pull Request Checklist

Resolves: 3385

  • Ensured tests pass and (if applicable) updated functional test output
  • Conformed to code style guidelines by running appropriate linting tools
  • Added tests for changed code
  • Updated documentation for changed code

Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every once in a while, Pygments changes how it renders code, causing our functional tests to break. When this happens, sometimes we pin the preceding version of Pygments, purely out of expediency.

I just experimented with version 2.18.0, and all tests pass, so for now I suggest we change the relevant line in this PR to: Pygments>=2.16.1

That way, we reduce the risk of further issues related to upper bounds, and we can always re-pin to a specific known working version if and when we must do so again.

(Side note for future pull requests: I recommend all pull requests be submitted via separate branches, as explained in more detail in: “Don’t Start Pull Requests from Your Main Branch”)

@justinmayer justinmayer merged commit 5687883 into getpelican:main Sep 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants