Skip to content

Commit

Permalink
Migrate DynamicForm to React (#3209)
Browse files Browse the repository at this point in the history
* create DynamicForm React component

* Render fields based on target in DynamicForm

* Add missing title property to fields

* Fix style properties in DynamicForm

* Render File fields in DynamicForm

* Use React for middle component instead of Angular

* Functional save button

* Update label style

* Render functional actions

* Handle file inputs

* Update render methods to fix code climate issues

* Fix ant input number showing duplicate arrows

* Update DynamicForm style to be vertical

* Separate imports from antd in DynamicForm

* Add Feedback Icons to DynamicForm

* Change Action props on DynamicForm
- use type and pullRight instead of class prop
- update data sources and destinations pages accordingly

* Remove setDefaults method from DynamicForm fields

* Update antd version

* Remove unnecessary class selectors

* Remove another unnecessary class selector
  • Loading branch information
gabrieldutra authored and arikfr committed Jan 15, 2019
1 parent 0c45d69 commit 823e4cc
Show file tree
Hide file tree
Showing 11 changed files with 383 additions and 173 deletions.
11 changes: 11 additions & 0 deletions client/app/assets/less/ant.less
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
@import '~antd/lib/style/core/iconfont.less';
@import '~antd/lib/style/core/motion.less';
@import '~antd/lib/input/style/index.less';
@import '~antd/lib/input-number/style/index.less';
@import '~antd/lib/date-picker/style/index.less';
@import '~antd/lib/modal/style/index.less';
@import '~antd/lib/tooltip/style/index.less';
@import '~antd/lib/select/style/index.less';
@import '~antd/lib/checkbox/style/index.less';
@import '~antd/lib/upload/style/index.less';
@import '~antd/lib/form/style/index.less';
@import '~antd/lib/button/style/index.less';
@import '~antd/lib/radio/style/index.less';
@import '~antd/lib/time-picker/style/index.less';
Expand Down Expand Up @@ -46,3 +50,10 @@
.ant-dropdown-in-bootstrap-modal {
z-index: 1050;
}

// Fix ant input number showing duplicate arrows
.ant-input-number-input::-webkit-outer-spin-button,
.ant-input-number-input::-webkit-inner-spin-button {
-webkit-appearance: none;
margin: 0;
}
41 changes: 0 additions & 41 deletions client/app/components/dynamic-form.html

This file was deleted.

124 changes: 0 additions & 124 deletions client/app/components/dynamic-form.js

This file was deleted.

Loading

0 comments on commit 823e4cc

Please sign in to comment.