Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the case when losing connection with the server #242

Closed
arikfr opened this issue Jul 20, 2014 · 1 comment
Closed

Handle the case when losing connection with the server #242

arikfr opened this issue Jul 20, 2014 · 1 comment
Labels
Frontend

Comments

@arikfr
Copy link
Member

arikfr commented Jul 20, 2014

Currently when there is network connection issue we fail silently -- in the case of dashboards we keep trying to reload, but in other cases the request just fails.

The desired behaviour should be:

  1. Retry to reload for X times.
  2. In case retries failed, show "Reconnect" message like HackPad has.

This is mainly needed when running queries, because otherwise the user will keep seeing the counter running up without anything really happening.

This should probably be handled by some global $http filter (interceptor?) of some sort.
@arikfr arikfr added this to the Next milestone Jul 20, 2014
@arikfr arikfr closed this as completed in 3960005 Jan 29, 2015
arikfr added a commit that referenced this issue Jan 29, 2015
@arikfr
Merge pull request #367 from EverythingMe/feature/offline
b76906b 
Fix #242: handle the case there is no connection to the server
arikfr added a commit that referenced this issue Feb 2, 2015
@arikfr
Revert "Fix #242: handle the case there is no connection to the server"
8d113da 
This reverts commit 3960005.

Conflicts:
	rd_ui/app/index.html
	rd_ui/bower.json
@arikfr
Copy link
Member Author

arikfr commented Feb 2, 2015

Offline.js proved to be causing issues on Chrome/Windows. Reverted, and will reimplement with our own simplified version.

@arikfr arikfr reopened this Feb 2, 2015
@arikfr arikfr removed this from the Next milestone Dec 10, 2015
@arikfr arikfr mentioned this issue May 1, 2016
Closed
@segevofer segevofer mentioned this issue Jan 17, 2017
Merged
@arikfr arikfr closed this as completed Jan 17, 2017
arikfr pushed a commit that referenced this issue Jan 19, 2017
@arikfr
Close #242: added ui indication for offline state
06186d9
jezdez pushed a commit to jezdez/redash that referenced this issue Nov 1, 2017
@alison985
fix pie chart multiple colors changed
e14ee5e 
getredash#242
washort pushed a commit to washort/redash that referenced this issue Dec 13, 2017
@alison985
fix pie chart multiple colors changed (re getredash#242)
15104f8
washort pushed a commit to washort/redash that referenced this issue Dec 15, 2017
fixup! fix pie chart multiple colors changed (re getredash#242)
748f834
washort pushed a commit to washort/redash that referenced this issue Jan 8, 2018
@alison985
change pie chart colors (re getredash#240)
affdfa7 
Incorporates: fix pie chart multiple colors changed (re getredash#242)
washort pushed a commit to washort/redash that referenced this issue Apr 30, 2018
@alison985 @jezdez
change pie chart colors (re getredash#240)
3c4b910 
Incorporates: fix pie chart multiple colors changed (re getredash#242)
washort pushed a commit to washort/redash that referenced this issue May 31, 2018
@alison985
change pie chart colors (re getredash#240)
7f0cb3d 
Incorporates: fix pie chart multiple colors changed (re getredash#242)
washort pushed a commit to washort/redash that referenced this issue Aug 11, 2018
@alison985
change pie chart colors (re getredash#240)
db948e5 
Incorporates: fix pie chart multiple colors changed (re getredash#242)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arikfr