[Cassandra] Change: test connection query #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yershalom
changed the title
arikfr
reviewed
Dec 20, 2016
| @@ -85,6 +86,9 @@ def run_query(self, query, user): | |||
| json_data = json.dumps(data, cls=JSONEncoder) | |||
|
|
|||
| error = None | |||
| except ReadTimeout as e: | |||
| error = e | |||
There was a problem hiding this comment.
Error needs to be a string. But why handle ReadTimeout in a special way?
There was a problem hiding this comment.
Because I want to pass the ReadTimeout if there is a read timeout, if you think that I can remove it so I will.
| enabled = True | ||
| except ImportError: | ||
| enabled = False | ||
|
|
||
|
|
||
| class Cassandra(BaseQueryRunner): | ||
| noop_query = "SELECT * FROM system" | ||
| noop_query = "SELECT * FROM system.compactions_in_progress" |
There was a problem hiding this comment.
Every user has access to this? Is there something like SELECT 1?
There was a problem hiding this comment.
No SELECT 1 for CQL.
Most of test queries goes in the same manner like SELECT now() FROM system.local;
arikfr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onnection