Refresh when changing (global) parameters #1919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woohoo! thanks :) |
|
@arikfr Any chance this could be merged? This is the biggest complaint I get from people using our dashboards, that they have to hit refresh,or forget to and end up misinterpreting dashboard numbers. |
|
This would be great improvement! |
|
Thanks, @seenivasanp, but we're going to solve this with better UI for parameters both on dashboards and queries. See the discussion in #2316, specifically the last comment: #2316 (comment) for details on how we're going to address this. Closing this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever parameters changed in the dashboard or query page,Url is changing but page reload is not happening.Here is the code for reloading the page when focus lost(parameters changed) in dashboard(only for global params).