Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing embeds with safe parameters #3495

Merged
merged 61 commits into from
Apr 2, 2019
Merged

Sharing embeds with safe parameters #3495

merged 61 commits into from
Apr 2, 2019

Commits on Mar 20, 2019

  1. change has_access and require_access signatures to work with the obje… 

    …cts that require access, instead of their groups
    Omer Lachish committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    3535dfd View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2019

  1. change has_access and require_access signatures to work with the obje… 

    …cts that require access, instead of their groups
    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    fc02fe7 View commit details
    Browse the repository at this point in the history

  2. use the textless endpoint (/api/queries/:id/results) for pristine 

    queriest
    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    eef39de View commit details
    Browse the repository at this point in the history

  3. Revert "use the textless endpoint (/api/queries/:id/results) for pris… 

    …tine"

This reverts commit cd2cee7.
    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    3c1ed5c View commit details
    Browse the repository at this point in the history

  4. go to textless /api/queries/:id/results by default

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    a3c543c View commit details
    Browse the repository at this point in the history

  5. change run_query's signature to accept a ParameterizedQuery instead of 

    constructing it inside
    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    b99f114 View commit details
    Browse the repository at this point in the history

  6. raise HTTP 400 when receiving invalid parameter values. Fixes #3394

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    2c48d36 View commit details
    Browse the repository at this point in the history

  7. support querystring params

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    d03d9e1 View commit details
    Browse the repository at this point in the history

  8. extract coercing of numbers to function, along with a friendlier 

    implementation
    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    637e985 View commit details
    Browse the repository at this point in the history

  9. wire embeds to textless endpoint

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    8776b40 View commit details
    Browse the repository at this point in the history

  10. allow users with view_only permissions to execute queries on the 

    textless endpoint, as it only allows safe queries to run
    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    7d9daa7 View commit details
    Browse the repository at this point in the history

  11. enqueue jobs for ApiUsers

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    1eeeef8 View commit details
    Browse the repository at this point in the history

  12. add parameters component for embeds

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    475f6f8 View commit details
    Browse the repository at this point in the history

  13. include existing parameters in embed code

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    ca9e665 View commit details
    Browse the repository at this point in the history

  14. fetch correct values for json requests

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    82ff905 View commit details
    Browse the repository at this point in the history

  15. remove previous embed parameter code

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    f4c22ca View commit details
    Browse the repository at this point in the history

  16. rename id to user_id

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    18c1876 View commit details
    Browse the repository at this point in the history

  17. support executing queries using Query api_keys by instantiating an Ap… 

    …iUser that would be able to execute the specific query
    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    7542ece View commit details
    Browse the repository at this point in the history

  18. bring back ALLOW_PARAMETERS_IN_EMBEDS (with link on deprecation comin… 

    …g up)
    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    0eb1963 View commit details
    Browse the repository at this point in the history

  19. show deprecation messages for ALLOW_PARAMETERS_IN_EMBEDS. Also, move 

    other message (email not verified) to use the same mechanism
    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    18d5b94 View commit details
    Browse the repository at this point in the history

  20. add link to forum message on setting deprecation

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    54d7d82 View commit details
    Browse the repository at this point in the history

  21. rephrase deprecation message

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    34f7762 View commit details
    Browse the repository at this point in the history

  22. add link to forum message regarding embed deprecation

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    96d56ee View commit details
    Browse the repository at this point in the history

  23. change API to /api/queries/:id/dropdowns/:dropdown_id

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    e19517c View commit details
    Browse the repository at this point in the history

  24. split to 2 different dropdown endpoints and implement the second

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    ef286a7 View commit details
    Browse the repository at this point in the history

  25. add test cases for /api/queries/:id/dropdowns/:id

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    87a9030 View commit details
    Browse the repository at this point in the history

  26. use new /dropdowns endpoint in frontend

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    b279b7a View commit details
    Browse the repository at this point in the history

  27. first e2e test for sharing embeds

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    aa59a89 View commit details
    Browse the repository at this point in the history

  28. Pleasing the CodeClimate overlords

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    9cc2de5 View commit details
    Browse the repository at this point in the history

  29. All glory to CodeClimate

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    0fce9c3 View commit details
    Browse the repository at this point in the history

  30. change has_access and require_access signatures to work with the obje… 

    …cts that require access, instead of their groups
    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    a40bc29 View commit details
    Browse the repository at this point in the history

  31. split has_access between normal users and ApiKey users

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    353bb9f View commit details
    Browse the repository at this point in the history

  32. remove residues from bad rebase

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    e95546b View commit details
    Browse the repository at this point in the history

  33. allow access to safe queries via api keys

    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    735a829 View commit details
    Browse the repository at this point in the history

  34. Merge branch 'change-has-access-signature' into allow-parameters-on-e… 

    …mbeds
    Omer Lachish committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    55eb7ce View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2019

  1. rename object to obj

    Omer Lachish committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    5ef2031 View commit details
    Browse the repository at this point in the history

  2. support both objects and group dicts in has_access and `require_acc… 

    …ess`
    Omer Lachish committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    1f16998 View commit details
    Browse the repository at this point in the history

  3. simplify permission tests once has_access accepts groups

    Omer Lachish committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    029c395 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'change-has-access-signature' into allow-parameters-on-e… 

    …mbeds
    Omer Lachish committed Mar 27, 2019
    Configuration menu
    Copy the full SHA
    0ff0cc9 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2019

  1. change has_access and require_access signatures to work with the obje… 

    …cts that require access, instead of their groups
    Omer Lachish committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    ff4dfbb View commit details
    Browse the repository at this point in the history

  2. rename object to obj

    Omer Lachish committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    71452cd View commit details
    Browse the repository at this point in the history

  3. support both objects and group dicts in has_access and `require_acc… 

    …ess`
    Omer Lachish committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    371c950 View commit details
    Browse the repository at this point in the history

  4. simplify permission tests once has_access accepts groups

    Omer Lachish committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    90a8eac View commit details
    Browse the repository at this point in the history

  5. Merge branch 'change-has-access-signature' into allow-parameters-on-e… 

    …mbeds
    Omer Lachish committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    9c6ce65 View commit details
    Browse the repository at this point in the history

  6. fix bad rebase

    Omer Lachish committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    c88d58a View commit details
    Browse the repository at this point in the history

  7. send embed parameters through POST data

    Omer Lachish committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    818fc27 View commit details
    Browse the repository at this point in the history

  8. no need to log is_api_key

    Omer Lachish committed Mar 28, 2019
    Configuration menu
    Copy the full SHA
    5770888 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2019

  1. Merge branch 'master' into allow-parameters-on-embeds

    Omer Lachish committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    c860314 View commit details
    Browse the repository at this point in the history

  2. move query fetching by api_key to within the Query model

    Omer Lachish committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    2c78937 View commit details
    Browse the repository at this point in the history

  3. fetch user by adding a get_by_id function on the User model

    Omer Lachish committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    34404b4 View commit details
    Browse the repository at this point in the history

  4. pass parameters as POST data (fixes test failure introduced by switching 

    from query string parameters to POST data)
    Omer Lachish committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    3d24835 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2019

  1. test the right thing - queries with safe parameters should be embeddable

    Omer Lachish committed Mar 31, 2019
    Configuration menu
    Copy the full SHA
    66251fd View commit details
    Browse the repository at this point in the history

  2. introduce cy.clickThrough

    Omer Lachish committed Mar 31, 2019
    Configuration menu
    Copy the full SHA
    4a32cdb View commit details
    Browse the repository at this point in the history

  3. add another Cypress test to make sure unsafe queries cannot be embedded

    Omer Lachish committed Mar 31, 2019
    Configuration menu
    Copy the full SHA
    304b178 View commit details
    Browse the repository at this point in the history

  4. serialize Parameters into query string

    Omer Lachish committed Mar 31, 2019
    Configuration menu
    Copy the full SHA
    17636ec View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2019

  1. set is_api_key as the last parameter to (hopefully) avoid 

    backward-dependency problems
    Omer Lachish committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    16a8a40 View commit details
    Browse the repository at this point in the history

  2. Update redash/models/parameterized_query.py 

    Co-Authored-By: rauchy <omer@rauchy.net>
    @arikfr
    arikfr and rauchy authored Apr 1, 2019
    Configuration menu
    Copy the full SHA
    1e7bd32 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into allow-parameters-on-embeds

    Omer Lachish committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    2efc9da View commit details
    Browse the repository at this point in the history

  4. attempt to fix empty percy snapshots

    Omer Lachish committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    8f81978 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. snap percies after DOM is fully loaded

    Omer Lachish committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    e912010 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'allow-parameters-on-embeds' of github.com:getredash/red… 

    …ash into allow-parameters-on-embeds
    Omer Lachish committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    64f1170 View commit details
    Browse the repository at this point in the history