Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation of "safe" parameter types #260

Closed
susodapop opened this issue Jul 3, 2019 · 0 comments
Closed

Add documentation of "safe" parameter types #260

susodapop opened this issue Jul 3, 2019 · 0 comments

Comments

@susodapop
Copy link
Contributor

Consistent with this PR on the main repo, we should have a note to say which parameter types can be embedded safely. This is a self-correcting problem because they'll eventually all be safe.
susodapop added a commit that referenced this issue Jul 3, 2019
@susodapop
Addresses #260. Notes which kinds of parameters are safe and verifies…
583f810 
… that dashboards cannot be shared if they use parameters.
@susodapop susodapop mentioned this issue Jul 3, 2019
Merged
susodapop added a commit that referenced this issue Jul 4, 2019
@susodapop
Clarify query parameter safety and embed rules (#263)
fac0fd1 
* Addresses #260. Notes which kinds of parameters are safe and verifies that dashboards cannot be shared if they use parameters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@susodapop