Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rrdom): Ignore invalid DOM attributes when diffing #213

Merged
merged 2 commits into from
Aug 26, 2024
Merged

fix(rrdom): Ignore invalid DOM attributes when diffing #213

merged 2 commits into from
Aug 26, 2024

Commits on Aug 15, 2024

  1. fix(rrdom): Ignore invalid DOM attributes when diffing 

    We encountered an issue where replays with invalid attributes (e.g. `@click`) would break rendering the replay after seeking. The exception bubbles up to [here](https://github.com/rrweb-io/rrweb/blob/62093d4385a09eb0980c2ac02d97eea5ce2882be/packages/rrweb/src/replay/index.ts#L270-L279), which means the replay will continue to play, but the replay mirror will be incomplete.
    @billyvg
    billyvg committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    bd984ac View commit details
    Browse the repository at this point in the history

  2. add warning

    @billyvg
    billyvg committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    058ed69 View commit details
    Browse the repository at this point in the history