Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on GCB during CI #1311

Closed
chadwhitacre opened this issue Feb 7, 2022 · 1 comment · Fixed by #1315
Closed

Build on GCB during CI #1311

chadwhitacre opened this issue Feb 7, 2022 · 1 comment · Fixed by #1315

Comments

@chadwhitacre
Copy link
Member

We broke CI in sentry and snuba with #1251 and #1289, due to (not fully understood) discrepancies in the environment between local dev, self-hosted CI, and sentry/snuba CI. The proposal here is to trigger a GCB runner similar to the ones in sentry and snuba to run as part of self-hosted CI to ensure that we're not breaking CI over there with our changes here. This should cover us in the future even if we don't fully understand the root cause for the problem(s) with #1251 and #1289.

This is an action item for INC-98 (private).

@chadwhitacre
Copy link
Member Author

chadwhitacre commented Feb 7, 2022

There are triggers set up in GCB that are wired to these two build files:

Those two files are similar but not identical. There are also files in other repos called cloudbuild.yaml. I don't know how much we want to DRY this up for this ticket, probably we should just do the minimum copy/paste to get the e2e tests going similar to sentry and snuba, which are identical at heart:

    args:
      - "-e"
      - "-c"
      - | 
        ./install.sh
        set +e
        ./test.sh
        test_return=$?
        set -e
        if [[ $test_return -ne 0 ]]; then
          echo "Test failed.";
          docker-compose ps;
          docker-compose logs;
          exit $test_return;
        fi

@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant