Add CI compose version 1.29.2 / 2.2.3 #1251

aminvakil · 2022-01-11T11:54:25Z

~~If it's causing issues (#1133 (comment)) why should we stick to it?~~

~~Also while we're here let's bump docker-compose 1.x version to latest release.~~

So this PR got changed in the way and at last min/max 1.x and 2.x versions of docker-compose added to CI as suggested by @chadwhitacre in #1251 (comment)

Also because of recent changes in 2.2.3 (docker/compose#9035) -T had to be added to some scripts using $dcr where output of it was getting used.

  -T, --no-TTY                Disable pseudo-noTty allocation. By default docker compose run allocates a TTY

chadwhitacre · 2022-01-11T14:55:20Z

Revert? 👀

aminvakil · 2022-01-11T14:56:12Z

Revert? eyes

Trying to see if the problem happens again with v2.0.1 or what? Sorry for the noise.

chadwhitacre · 2022-01-11T14:58:56Z

Ah, gotcha. I figured it was #1171. :-/

aminvakil · 2022-01-11T15:27:29Z

I'm running self-hosted (21.11.0) with docker compose v2.2.3 and I don't have a problem...

aminvakil · 2022-01-18T12:19:25Z

OK, So I went and checked this PR a couple of times during the past few days and couldn't figure out what is wrong with 2.2.3, last solution I have is to check every release between 2.0.1 and 2.2.3 to see what breaks where :) and then figure out why

CI Passed:

So the regression starts with 2.2.3 (https://github.com/docker/compose/releases/tag/v2.2.3) itself.

aminvakil · 2022-01-18T13:48:41Z

sentry-self-hosted-relay-1                                      "/bin/bash /docker-e…"   relay                                      restarting

relay stucks in a loop:

2022-01-18T13:22:01.7151325Z sentry-self-hosted-relay-1                                     | error: could not parse json config file (file /work/.relay/credentials.json)
2022-01-18T13:22:01.7152059Z sentry-self-hosted-relay-1                                     |   caused by: EOF while parsing a value at line 1 column 0
2022-01-18T13:22:01.7152692Z sentry-self-hosted-relay-1                                     | error: could not parse json config file (file /work/.relay/credentials.json)
2022-01-18T13:22:01.7153321Z sentry-self-hosted-relay-1                                     |   caused by: EOF while parsing a value at line 1 column 0
2022-01-18T13:22:01.7153963Z sentry-self-hosted-relay-1                                     | error: could not parse json config file (file /work/.relay/credentials.json)
2022-01-18T13:22:01.7154568Z sentry-self-hosted-relay-1                                     |   caused by: EOF while parsing a value at line 1 column 0
2022-01-18T13:22:01.7155214Z sentry-self-hosted-relay-1                                     | error: could not parse json config file (file /work/.relay/credentials.json)
2022-01-18T13:22:01.7155841Z sentry-self-hosted-relay-1                                     |   caused by: EOF while parsing a value at line 1 column 0
2022-01-18T13:22:01.7156460Z sentry-self-hosted-relay-1                                     | error: could not parse json config file (file /work/.relay/credentials.json)
2022-01-18T13:22:01.7157079Z sentry-self-hosted-relay-1                                     |   caused by: EOF while parsing a value at line 1 column 0
2022-01-18T13:22:01.7157698Z sentry-self-hosted-relay-1                                     | error: could not parse json config file (file /work/.relay/credentials.json)
2022-01-18T13:22:01.7158316Z sentry-self-hosted-relay-1                                     |   caused by: EOF while parsing a value at line 1 column 0

BYK · 2022-01-18T15:29:46Z

@aminvakil could this be some sort of Unix/Windows line ending issue?

BYK · 2022-01-18T15:31:43Z

@aminvakil, actually, I bet docker compose 2.2.3 is outputting some random/garbage values in the run output at this step:

self-hosted/install/relay-credentials.sh

Lines 16 to 20 in 13d14e8

    
           $dcr \ 
        
             --no-deps \ 
        
             --volume "$(pwd)/$RELAY_CONFIG_YML:/tmp/config.yml" \ 
        
             relay --config /tmp credentials generate --stdout \ 
        
             > "$RELAY_CREDENTIALS_JSON"

Producing an invalid YAML, causing relay to fail. That means getsentry/relay#1169 is invalid and we should address the issue here or with docker compose itself directly.

untitaker · 2022-01-18T16:49:54Z

@BYK are there any issues with not using --stdout and generating the credentials in a mounted volume?

I think the bug described in the comment above might also purely exist because you're redirecting stdout to a file instead of letting Relay create the file, because that creates an empty file before the relay process starts.

BYK · 2022-01-18T16:57:28Z

@untitaker using a volume is fine here but Relay does not like that scenario: getsentry/relay#564

aminvakil · 2022-01-19T09:06:30Z

I removed putting output to file to see what is the output in 6366592.
It seems that nothing gets generated at all using 2.2.3
https://github.com/getsentry/self-hosted/runs/4865126485?check_suite_focus=true#step:4:498
Same job with 1.29.2 though:
https://github.com/getsentry/self-hosted/runs/4865126429?check_suite_focus=true#step:4:717

I guess it's related to docker/compose#9035 which fixed another bug reported by @chadwhitacre :)

untitaker · 2022-01-19T09:41:51Z

using a volume is fine here but Relay does not like that scenario

That linked PR only changes relay's behavior when using the --stdout flag, but to be clear i propose not using that flag, not using > and letting relay create the credentials file itself, not the shell

aminvakil · 2022-01-19T10:07:26Z

Closing and reopening to see if kafka thing is temporary or not.

BYK · 2022-01-19T15:40:34Z

@aminvakil let's try what @untitaker suggest and remove the --stdout flag?

chadwhitacre · 2022-01-19T17:01:03Z

Oh wow I've been missing the party. 🍿

.github/workflows/test.yml

aminvakil · 2022-01-23T10:27:45Z

@BYK @chadwhitacre Sorry for answering late. I wanted to give myself more time to think about this.

@aminvakil let's try what @untitaker suggest and remove the --stdout flag?

I propose keeping this PR as it is, but create another PR which changes relay credentials generation as @untitaker suggests, and take a look at this PR after that has been changed, what do you think?

what do you think of testing against more than two versions of Docker Compose? How about min/max of v1 and min/max of v2? So ...

Sure, why not? I say add them later after merging the relay credential PR.

BYK

If -T fixes things, I actually like this approach more. Should we bake that into the $dcr shortcut?

Also, we either need to add the old versions to the matrix too or update the required checks in branch protection rules @chadwhitacre

aminvakil · 2022-01-24T09:25:08Z

If -T fixes things, I actually like this approach more. Should we bake that into the $dcr shortcut?

I'm not sure how it would act on older docker-compose versions or different parts which $dcr is getting used, I say let's not change everything everywhere :) (at least for now)

BYK · 2022-01-24T09:56:17Z

I say let's not change everything everywhere :) (at least for now)

Then please explain why that is needed on the kafka thing or revert that? 🤣

aminvakil · 2022-01-24T14:41:07Z

Last failed run was because of docker/compose#6704

chadwhitacre · 2022-01-24T15:32:24Z

Interesting, docker/compose#9035, which introduced the need for -T w/ 2.2.3, was the fix for #1133. Oh the tangled web we weave. 😂 😭

install/relay-credentials.sh

chadwhitacre

I dig it! 👍

chadwhitacre · 2022-01-24T17:37:34Z

👏 👏 @aminvakil as well as @BYK for wrestling this to the ground. It was supposed to be easy! 🙈

aminvakil · 2022-01-24T17:49:38Z

@BYK Thank you for helping me through this!
@chadwhitacre Thanks for merging!

This reverts commit 3abbb3e.

#1272)" This reverts commit da8f490.

* Revert "Revert "Add CI compose version 1.29.2 / 2.0.1 / 2.2.3 (#1251)" (#1272)" This reverts commit da8f490. * Drop back to -T because long opt is Compose 2+ Admin-merging with approvals from outside contributors (All-seeing eye, are you seeing this? ;)

aminvakil changed the title ~~Bump CI compose version 2.2.3~~ Bump CI compose version 1.29.2 / 2.2.3 Jan 11, 2022

chadwhitacre mentioned this pull request Jan 11, 2022

install.sh hangs during superuser creation under Docker Compose v2 #1133

Closed

aminvakil mentioned this pull request Jan 18, 2022

Initialize broken using docker-compose 2.2.3 getsentry/relay#1169

Closed

aminvakil closed this Jan 19, 2022

aminvakil reopened this Jan 19, 2022

chadwhitacre reviewed Jan 19, 2022

View reviewed changes

.github/workflows/test.yml Show resolved Hide resolved

aminvakil mentioned this pull request Jan 23, 2022

Do not to use --stdout for relay credential generate #1267

Closed

BYK approved these changes Jan 24, 2022

View reviewed changes

aminvakil closed this Jan 24, 2022

aminvakil reopened this Jan 24, 2022

aminvakil force-pushed the ci_docker_compose_v2.2.3 branch 2 times, most recently from b36708d to f34f46f Compare January 24, 2022 11:45

aminvakil force-pushed the ci_docker_compose_v2.2.3 branch from 637c429 to a1c91ae Compare January 24, 2022 12:10

aminvakil closed this Jan 24, 2022

aminvakil reopened this Jan 24, 2022

aminvakil force-pushed the ci_docker_compose_v2.2.3 branch from a1c91ae to 32e1975 Compare January 24, 2022 14:53

chadwhitacre reviewed Jan 24, 2022

View reviewed changes

install/relay-credentials.sh Outdated Show resolved Hide resolved

aminvakil added 2 commits January 24, 2022 19:55

Disable pseudo-noTty allocation for relay creation

eefbe84

Disable pseudo-noTty allocation in create-kafka-topics

1b5eb5c

aminvakil force-pushed the ci_docker_compose_v2.2.3 branch from 32e1975 to 1b5eb5c Compare January 24, 2022 16:26

chadwhitacre approved these changes Jan 24, 2022

View reviewed changes

chadwhitacre merged commit 3abbb3e into getsentry:master Jan 24, 2022

aminvakil deleted the ci_docker_compose_v2.2.3 branch January 24, 2022 17:49

chadwhitacre added a commit that referenced this pull request Jan 24, 2022

Revert "Add CI compose version 1.29.2 / 2.0.1 / 2.2.3 (#1251)"

4443823

This reverts commit 3abbb3e.

chadwhitacre mentioned this pull request Jan 24, 2022

Revert "Add CI compose version 1.29.2 / 2.2.3" #1272

Merged

chadwhitacre added a commit that referenced this pull request Jan 24, 2022

Revert "Add CI compose version 1.29.2 / 2.0.1 / 2.2.3 (#1251)" (#1272)

da8f490

This reverts commit 3abbb3e.

This was referenced Feb 1, 2022

Debug CI #1273

Closed

Clean up relay credentials generation #1289

Merged

chadwhitacre added a commit that referenced this pull request Feb 2, 2022

Revert "Revert "Add CI compose version 1.29.2 / 2.0.1 / 2.2.3 (#1251)" (

ba650f3

#1272)" This reverts commit da8f490.

chadwhitacre mentioned this pull request Feb 2, 2022

Add CI compose version 1.29.2 / 2.0.1 / 2.2.3 #1290

Merged

chadwhitacre added a commit that referenced this pull request Feb 2, 2022

Bring in second -T instance from #1251

0fcefa7

chadwhitacre mentioned this pull request Feb 2, 2022

fix: unbound variable _group in reset/dc-detect-version script (#1283) #1284

Merged

chadwhitacre mentioned this pull request Feb 7, 2022

Build on GCB during CI #1311

Closed

github-actions bot locked and limited conversation to collaborators Feb 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CI compose version 1.29.2 / 2.2.3 #1251

Add CI compose version 1.29.2 / 2.2.3 #1251

aminvakil commented Jan 11, 2022 •

edited

Loading

chadwhitacre commented Jan 11, 2022

aminvakil commented Jan 11, 2022

chadwhitacre commented Jan 11, 2022

aminvakil commented Jan 11, 2022

aminvakil commented Jan 18, 2022 •

edited

Loading

aminvakil commented Jan 18, 2022

BYK commented Jan 18, 2022

BYK commented Jan 18, 2022

untitaker commented Jan 18, 2022 •

edited

Loading

BYK commented Jan 18, 2022

aminvakil commented Jan 19, 2022 •

edited

Loading

untitaker commented Jan 19, 2022

aminvakil commented Jan 19, 2022

BYK commented Jan 19, 2022

chadwhitacre commented Jan 19, 2022

aminvakil commented Jan 23, 2022 •

edited

Loading

BYK left a comment

aminvakil commented Jan 24, 2022

BYK commented Jan 24, 2022

aminvakil commented Jan 24, 2022

chadwhitacre commented Jan 24, 2022

chadwhitacre left a comment

chadwhitacre commented Jan 24, 2022

aminvakil commented Jan 24, 2022

Add CI compose version 1.29.2 / 2.2.3 #1251

Add CI compose version 1.29.2 / 2.2.3 #1251

Conversation

aminvakil commented Jan 11, 2022 • edited Loading

chadwhitacre commented Jan 11, 2022

aminvakil commented Jan 11, 2022

chadwhitacre commented Jan 11, 2022

aminvakil commented Jan 11, 2022

aminvakil commented Jan 18, 2022 • edited Loading

aminvakil commented Jan 18, 2022

BYK commented Jan 18, 2022

BYK commented Jan 18, 2022

untitaker commented Jan 18, 2022 • edited Loading

BYK commented Jan 18, 2022

aminvakil commented Jan 19, 2022 • edited Loading

untitaker commented Jan 19, 2022

aminvakil commented Jan 19, 2022

BYK commented Jan 19, 2022

chadwhitacre commented Jan 19, 2022

aminvakil commented Jan 23, 2022 • edited Loading

BYK left a comment

Choose a reason for hiding this comment

aminvakil commented Jan 24, 2022

BYK commented Jan 24, 2022

aminvakil commented Jan 24, 2022

chadwhitacre commented Jan 24, 2022

chadwhitacre left a comment

Choose a reason for hiding this comment

chadwhitacre commented Jan 24, 2022

aminvakil commented Jan 24, 2022

aminvakil commented Jan 11, 2022 •

edited

Loading

aminvakil commented Jan 18, 2022 •

edited

Loading

untitaker commented Jan 18, 2022 •

edited

Loading

aminvakil commented Jan 19, 2022 •

edited

Loading

aminvakil commented Jan 23, 2022 •

edited

Loading