Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

benefiting of manifest merging when minSdk < 21 #159

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Nov 19, 2019

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

benefiting of manifest merging when minSdk < 21

💡 Motivation and Context

if you wanna support NDK >= 21 but also to support Android SDK < 21, you need to set this merging strategy.

  <uses-sdk
    tools:overrideLibrary="io.sentry.android, io.sentry.android.ndk"/>

with this PR, you just need:

  <uses-sdk
    tools:overrideLibrary="io.sentry.android"/>

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@bruno-garcia bruno-garcia merged commit d1a514b into master Nov 21, 2019
@bruno-garcia bruno-garcia deleted the enha/minsdk_merge branch November 21, 2019 00:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants