-
-
Notifications
You must be signed in to change notification settings - Fork 32
update ndk for new sentry-native version #235
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you test it running the sentry-sample on an emulator and clicking on the Crash from native (segfault) button and see if the events get sent? restart the app after getting crashed to be able to send the event btw.
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
=========================================
Coverage 57.27% 57.27%
Complexity 567 567
=========================================
Files 72 72
Lines 2708 2708
Branches 234 234
=========================================
Hits 1551 1551
Misses 1042 1042
Partials 115 115 Continue to review full report at Codecov.
|
got that working now. will coordinate with @jan-auer to further discuss when which part of code should land. |
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
=========================================
Coverage ? 57.26%
Complexity ? 576
=========================================
Files ? 73
Lines ? 2761
Branches ? 234
=========================================
Hits ? 1581
Misses ? 1062
Partials ? 118 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📢 Type of change
📜 Description
Adapt to API changes in
sentry-native
, and temporarily point to a specific commit that builds.💡 Motivation and Context
💚 How did you test it?
So far only checked that it builds
📝 Checklist
🔮 Next steps