Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

update ndk for new sentry-native version #235

Merged
merged 20 commits into from
Feb 3, 2020
Merged

Conversation

Swatinem
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Adapt to API changes in sentry-native, and temporarily point to a specific commit that builds.

💡 Motivation and Context

💚 How did you test it?

So far only checked that it builds

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you test it running the sentry-sample on an emulator and clicking on the Crash from native (segfault) button and see if the events get sent? restart the app after getting crashed to be able to send the event btw.

@codecov-io
Copy link

codecov-io commented Jan 16, 2020

Codecov Report

Merging #235 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #235   +/-   ##
=========================================
  Coverage     57.27%   57.27%           
  Complexity      567      567           
=========================================
  Files            72       72           
  Lines          2708     2708           
  Branches        234      234           
=========================================
  Hits           1551     1551           
  Misses         1042     1042           
  Partials        115      115

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c92403...a31cabb. Read the comment docs.

@marandaneto marandaneto changed the title update ndk for new sentry-native version WIP - update ndk for new sentry-native version Jan 16, 2020
@Swatinem
Copy link
Member Author

and see if the events get sent?

got that working now. will coordinate with @jan-auer to further discuss when which part of code should land.

@Swatinem Swatinem changed the title WIP - update ndk for new sentry-native version update ndk for new sentry-native version Jan 27, 2020
@codecov-io
Copy link

codecov-io commented Jan 28, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@edae84d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #235   +/-   ##
=========================================
  Coverage          ?   57.26%           
  Complexity        ?      576           
=========================================
  Files             ?       73           
  Lines             ?     2761           
  Branches          ?      234           
=========================================
  Hits              ?     1581           
  Misses            ?     1062           
  Partials          ?      118

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edae84d...5fc31db. Read the comment docs.

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marandaneto marandaneto merged commit 9e19eaf into master Feb 3, 2020
@marandaneto marandaneto deleted the native-c-uplift branch February 3, 2020 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants