This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
refactoring breadcrumbs callback #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
approved these changes
Jan 18, 2020
| @@ -70,7 +70,7 @@ android { | |||
| dependencies { | |||
| implementation(fileTree(mapOf("dir" to "libs", "include" to listOf("*.jar")))) | |||
|
|
|||
| implementation("io.sentry:sentry-android:2.0.0-beta02") | |||
| implementation("io.sentry:sentry-android:2.0.0-rc01") | |||
There was a problem hiding this comment.
Is this supposed to go in this PR?
There was a problem hiding this comment.
it could be separated, but it doesn't affect anything, my bad
| scope.setUser(user); | ||
| scope.setTag("tag", "tag"); | ||
| }); | ||
| Sentry.addBreadcrumb("Breadcrumb"); |
There was a problem hiding this comment.
We could demo here the beforeBreadcrumb dropping a crumb too. Would be nice.
There was a problem hiding this comment.
it should be done on MyApplication though.
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
============================================
- Coverage 58.13% 57.76% -0.37%
+ Complexity 574 569 -5
============================================
Files 72 72
Lines 2706 2692 -14
Branches 237 235 -2
============================================
- Hits 1573 1555 -18
- Misses 1014 1016 +2
- Partials 119 121 +2
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
refactoring breadcrumbs callback.
💡 Motivation and Context
callbacks were called on Hub and Scope, but could it be placed and logged together.
💚 How did you test it?
executing it, there is unit tests already.
📝 Checklist
🔮 Next steps