Skip to content

Commit

Permalink
fix conflict
Browse files Browse the repository at this point in the history
  • Loading branch information
marandaneto committed Oct 21, 2022
2 parents db88adc + 068b12d commit 1fc2ad4
Show file tree
Hide file tree
Showing 7 changed files with 28 additions and 28 deletions.
1 change: 0 additions & 1 deletion Sources/Sentry/Public/SentryOptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,6 @@ NS_SWIFT_NAME(Options)
*/
@property (nonatomic, retain) NSArray *tracePropagationTargets;


/**
* When enabled, the SDK captures HTTP Client errors. Default value is NO.
*/
Expand Down
4 changes: 2 additions & 2 deletions Sources/Sentry/SentryEvent.m
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#import "NSDate+SentryExtras.h"
#import "NSDictionary+SentrySanitize.h"
#import "SentryBreadcrumb.h"
#import "SentryRequest.h"
#import "SentryClient.h"
#import "SentryCurrentDate.h"
#import "SentryDebugMeta.h"
Expand All @@ -11,6 +10,7 @@
#import "SentryLevelMapper.h"
#import "SentryMessage.h"
#import "SentryMeta.h"
#import "SentryRequest.h"
#import "SentryStacktrace.h"
#import "SentryThread.h"
#import "SentryUser.h"
Expand Down Expand Up @@ -158,7 +158,7 @@ - (void)addSimpleProperties:(NSMutableDictionary *)serializedData
forKey:@"start_timestamp"];
}
}

if (nil != self.request) {
[serializedData setValue:[self.request serialize] forKey:@"request"];
}
Expand Down
38 changes: 19 additions & 19 deletions Sources/Sentry/SentryNetworkTracker.m
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
#import "SentryNetworkTracker.h"
#import "SentryBaggage.h"
#import "SentryBreadcrumb.h"
#import "SentryClient+Private.h"
#import "SentryEvent.h"
#import "SentryException.h"
#import "SentryMechanism.h"
#import "SentryRequest.h"
#import "SentryStacktrace.h"
#import "SentryThread.h"
#import "SentryHub+Private.h"
#import "SentryClient+Private.h"
#import "SentryThreadInspector.h"
#import "SentryLog.h"
#import "SentryMechanism.h"
#import "SentryRequest.h"
#import "SentrySDK+Private.h"
#import "SentryScope+Private.h"
#import "SentrySerialization.h"
#import "SentryStacktrace.h"
#import "SentryThread.h"
#import "SentryThreadInspector.h"
#import "SentryTraceContext.h"
#import "SentryTraceHeader.h"
#import "SentryTracer.h"
Expand Down Expand Up @@ -224,7 +224,8 @@ - (void)urlSessionTaskResume:(NSURLSessionTask *)sessionTask

- (void)urlSessionTask:(NSURLSessionTask *)sessionTask setState:(NSURLSessionTaskState)newState
{
if (!self.isNetworkTrackingEnabled && !self.isNetworkBreadcrumbEnabled && !self.isCaptureFailedRequests) {
if (!self.isNetworkTrackingEnabled && !self.isNetworkBreadcrumbEnabled
&& !self.isCaptureFailedRequests) {
return;
}

Expand Down Expand Up @@ -258,7 +259,7 @@ - (void)urlSessionTask:(NSURLSessionTask *)sessionTask setState:(NSURLSessionTas

if (sessionTask.state == NSURLSessionTaskStateRunning) {
[self captureEvent:sessionTask];

[self addBreadcrumbForSessionTask:sessionTask];

NSInteger responseStatusCode = [self urlResponseStatusCode:sessionTask.response];
Expand Down Expand Up @@ -288,30 +289,29 @@ - (void)urlSessionTask:(NSURLSessionTask *)sessionTask setState:(NSURLSessionTas
- (void)captureEvent:(NSURLSessionTask *)sessionTask
{
NSInteger responseStatusCode = [self urlResponseStatusCode:sessionTask.response];

// TODO: check the string contains and regex
if (!self.isCaptureFailedRequests) {
return;
}

// TODO: check the range
if (responseStatusCode == 201) {
return;
}
NSString *message = [NSString stringWithFormat:@"HTTP Client Error with status code: %li",
(long)(responseStatusCode)];

NSString *message = [NSString
stringWithFormat:@"HTTP Client Error with status code: %li", (long)(responseStatusCode)];

SentryEvent *event = [[SentryEvent alloc] initWithLevel:kSentryLevelError];

SentryThreadInspector *threadInspector = SentrySDK.currentHub.getClient.threadInspector;
NSArray<SentryThread *> *threads = [threadInspector getCurrentThreadsWithStackTrace];

SentryException *sentryException = [[SentryException alloc] initWithValue:message
type:@"HTTP-ClientError"];
sentryException.mechanism = [[SentryMechanism alloc] initWithType:@"SentryNetworkTrackingIntegration"];


if (threads.count > 0) {
SentryStacktrace *sentryStacktrace = [threads[0] stacktrace];
sentryStacktrace.snapshot = @(YES);
Expand All @@ -321,14 +321,14 @@ - (void)captureEvent:(NSURLSessionTask *)sessionTask
// [threads enumerateObjectsUsingBlock:^(SentryThread *_Nonnull obj, NSUInteger idx,
// BOOL *_Nonnull stop) { obj.current = [NSNumber numberWithBool:idx == 0]; }];
}

SentryRequest *request = [[SentryRequest alloc] init];

NSURLRequest *myRequest = (NSURLRequest *)sessionTask.currentRequest;

NSURL *url = [[sessionTask currentRequest] URL];
request.url = url.absoluteString;

request.fragment = url.fragment;
request.queryString = url.query;
request.method = myRequest.HTTPMethod;
Expand All @@ -343,7 +343,7 @@ - (void)captureEvent:(NSURLSessionTask *)sessionTask

event.exceptions = @[ sentryException ];
event.request = request;

NSHTTPURLResponse *myResponse = (NSHTTPURLResponse *)sessionTask.response;

NSMutableDictionary<NSString *, id> *context = [[NSMutableDictionary alloc] init];;
Expand Down
5 changes: 3 additions & 2 deletions Sources/Sentry/SentryNetworkTrackingIntegration.m
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,13 @@ - (BOOL)installWithOptions:(SentryOptions *)options
if (options.enableNetworkBreadcrumbs) {
[SentryNetworkTracker.sharedInstance enableNetworkBreadcrumbs];
}

if (options.enableCaptureFailedRequests) {
[SentryNetworkTracker.sharedInstance enableCaptureFailedRequests];
}

if (shouldEnableNetworkTracking || options.enableNetworkBreadcrumbs || options.enableCaptureFailedRequests) {
if (shouldEnableNetworkTracking || options.enableNetworkBreadcrumbs
|| options.enableCaptureFailedRequests) {
[SentryNetworkTrackingIntegration swizzleURLSessionTask];
return YES;
} else {
Expand Down
2 changes: 1 addition & 1 deletion Sources/Sentry/SentryOptions.m
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ - (BOOL)validateOptions:(NSDictionary<NSString *, id> *)options

[self setBool:options[@"enableAutoPerformanceTracking"]
block:^(BOOL value) { self->_enableAutoPerformanceTracking = value; }];

[self setBool:options[@"enableCaptureFailedRequests"]
block:^(BOOL value) { self->_enableCaptureFailedRequests = value; }];

Expand Down
4 changes: 2 additions & 2 deletions Sources/Sentry/SentryRequest.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ NS_SWIFT_NAME(Request)
@property (atomic, copy) NSString *_Nullable cookies;

/**
* Optional: A dictionary of submitted headers.
*/
* Optional: A dictionary of submitted headers.
*/
@property (nonatomic, strong) NSDictionary<NSString *, NSString *> *_Nullable headers;

/**
Expand Down
2 changes: 1 addition & 1 deletion Sources/Sentry/SentryStacktrace.m
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ - (void)fixDuplicateFrames
[serializedData setValue:self.registers forKey:@"registers"];
}
[serializedData setValue:self.snapshot forKey:@"snapshot"];

return serializedData;
}

Expand Down

0 comments on commit 1fc2ad4

Please sign in to comment.