Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky SentryHttpTransportTests.testFlush_BlocksCallingThread_TimesOut #2334

Closed
armcknight opened this issue Oct 26, 2022 · 1 comment · Fixed by #2370
Closed

Fix flaky SentryHttpTransportTests.testFlush_BlocksCallingThread_TimesOut #2334

armcknight opened this issue Oct 26, 2022 · 1 comment · Fixed by #2370
Assignees
@philipphofmann
Labels
Platform: Cocoa Type: Flaky Test

Comments

@armcknight
Copy link
Member

Description

Have seen it flake before, here is the latest one

failed on a PR that only fixed typos: https://github.com/getsentry/sentry-cocoa/actions/runs/3331647544/jobs/5511643619#step:9:40
succeeded on retry:https://github.com/getsentry/sentry-cocoa/actions/runs/3331647544/jobs/5512294994
@philipphofmann philipphofmann self-assigned this Nov 2, 2022
@kevinrenskers
Copy link
Contributor

kevinrenskers commented Nov 2, 2022 •
edited
Loading

Failed in another PR: https://github.com/getsentry/sentry-cocoa/actions/runs/3378167037/jobs/5608067081
But why is it not disabled yet, when it's flaky?

philipphofmann added a commit that referenced this issue Nov 8, 2022
@philipphofmann
fix: Too long flush duration
ce97c7e 
Move calculation of the flush dispatch time to the beginning of the
flush function to avoid any code until the call to dispatch_group_wait
adds up to the total flush duration.

Fixes GH-2334, GH-2340
@philipphofmann philipphofmann mentioned this issue Nov 8, 2022
Merged
5 tasks
philipphofmann added a commit that referenced this issue Nov 10, 2022
@philipphofmann
fix: Too long flush duration (#2370)
e2a3f3e 
Move the calculation of the flush dispatch time to the beginning of the
flush function to avoid any code until the call to dispatch_group_wait
adds up to the total flush duration.

Fixes GH-2334, GH-2340
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philipphofmann philipphofmann

Labels
Platform: Cocoa Type: Flaky Test
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Too long flush duration getsentry/sentry-cocoa
4 participants
@kevinrenskers @philipphofmann @armcknight @brustolin