fix: Detecting ANRs as false OOMs #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OOM logic falsely detected ANRs as OOMs. This is fixed now by adding a tracker for ANRs, which doesn't report ANR events to Sentry yet. Fixes GH-1645
philipphofmann
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1695 +/- ##
==========================================
+ Coverage 94.70% 94.77% +0.06%
==========================================
Files 162 167 +5
Lines 7442 7579 +137
==========================================
+ Hits 7048 7183 +135
- Misses 394 396 +2
Continue to review full report at Codecov.
|
brustolin
reviewed
Mar 15, 2022
brustolin
reviewed
Mar 15, 2022
brustolin
reviewed
Mar 15, 2022
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
brustolin
reviewed
Mar 16, 2022
brustolin
reviewed
Mar 16, 2022
brustolin
reviewed
Mar 16, 2022
| { | ||
| @synchronized(self) { | ||
| SentryAppState *appState = [self.fileManager readAppState]; | ||
| if (nil != appState) { |
There was a problem hiding this comment.
What about the first run? Will readAppState create an empty file for us on read?
There was a problem hiding this comment.
As we currently only use this for creating OOMs and we use it to avoid creating false OOMs, we don't need to worry about this right now, as we only create an OOM if there is an app state.
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
brustolin
approved these changes
Mar 16, 2022
11 tasks
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
The OOM logic falsely detected ANRs as OOMs. This is fixed now by
adding a tracker for ANRs, which doesn't report ANR events to
Sentry yet.
💡 Motivation and Context
Fixes GH-1645
💚 How did you test it?
Unit tests, simulator, and on an iPhone.
📝 Checklist
🔮 Next steps
Docs PR getsentry/sentry-docs#4837