Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix VLC integration test #2251

Merged
merged 3 commits into from
Oct 4, 2022
Merged

fix: Fix VLC integration test #2251

merged 3 commits into from
Oct 4, 2022

Conversation

kevinrenskers
Copy link
Contributor

@kevinrenskers kevinrenskers commented Oct 4, 2022 •
edited
Loading

Closes #2246

#skip-changelog

@kevinrenskers
Use iOS 16.0
69f1b9b
@kevinrenskers
Merge branch 'master' into fix/fix-vlc-integration-test
799b325 
* master:
  ci: update and pin GHA to commit hash (#2249)

# Conflicts:
#	.github/workflows/integration-tests.yml
@kevinrenskers
Copy link
Contributor Author

Holy schnitzel, why do these tests take so long though 😓

philipphofmann
philipphofmann approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@philipphofmann
Copy link
Member

Holy schnitzel

Austrian style 🇦🇹 😁

@philipphofmann philipphofmann merged commit ee127f4 into master Oct 4, 2022
@philipphofmann philipphofmann deleted the fix/fix-vlc-integration-test branch October 4, 2022 13:51
@philipphofmann philipphofmann mentioned this pull request Oct 4, 2022
Merged
kevinrenskers added a commit that referenced this pull request Oct 4, 2022
@kevinrenskers
Merge branch 'master' into ref/isOOM-race-condition
b85a582 
* master:
  ci: Fix Validate podspec (#2253)
  fix: Fix VLC integration test (#2251)
  ci: update and pin GHA to commit hash (#2249)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipphofmann philipphofmann philipphofmann approved these changes

@brustolin brustolin Awaiting requested review from brustolin

@armcknight armcknight Awaiting requested review from armcknight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Integration Tests / vlc-tests" workflow failure
2 participants
@kevinrenskers @philipphofmann