Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix stuck tests on master branch #2285

Merged
merged 6 commits into from
Oct 13, 2022

Conversation

philipphofmann
Copy link
Member

Some tests get stuck on the master branch, which uses TestCI configuration. The code that gets stuck is accessing UIScreen.mainScreen in SentryCrashIntegration. This is just a workaround; the actual fix will be done with #2284.

#skip-changelog

Some tests get stuck on the master branch which uses TestCI
configuration. The code that gets stuck is accessing UIScreen.mainScreen
in SentryCrashIntegration. This is just a workaround, the actual fix will be done
with #2284.
@github-actions
Copy link

github-actions bot commented Oct 13, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1267.02 ms 1284.38 ms 17.36 ms
Size 20.50 KiB 335.95 KiB 315.44 KiB

Baseline results on branch: master

Startup times

Revision Plain With Sentry Diff
c2a9b60 1222.10 ms 1240.62 ms 18.52 ms
9231f60 1256.78 ms 1267.74 ms 10.96 ms
5025d2e 1248.52 ms 1251.72 ms 3.20 ms
c61d869 1255.92 ms 1267.47 ms 11.55 ms
5025d2e 1245.14 ms 1268.58 ms 23.44 ms
b869536 1250.37 ms 1274.84 ms 24.47 ms
3861500 1214.88 ms 1232.48 ms 17.60 ms
e958899 1233.02 ms 1261.86 ms 28.84 ms
0e2e593 1234.78 ms 1266.10 ms 31.32 ms
a5ca27b 1231.31 ms 1252.56 ms 21.25 ms

App size

Revision Plain With Sentry Diff
c2a9b60 20.50 KiB 333.54 KiB 313.04 KiB
9231f60 20.51 KiB 333.58 KiB 313.07 KiB
5025d2e 20.51 KiB 331.79 KiB 311.28 KiB
c61d869 20.51 KiB 333.10 KiB 312.59 KiB
5025d2e 20.51 KiB 331.79 KiB 311.28 KiB
b869536 20.51 KiB 331.79 KiB 311.28 KiB
3861500 20.50 KiB 333.54 KiB 313.04 KiB
e958899 20.51 KiB 331.92 KiB 311.41 KiB
0e2e593 20.50 KiB 333.88 KiB 313.38 KiB
a5ca27b 20.51 KiB 331.81 KiB 311.31 KiB

Previous results on branch: test/fix-failing-master-tests

Startup times

Revision Plain With Sentry Diff
4fc4521 1239.45 ms 1254.30 ms 14.85 ms

App size

Revision Plain With Sentry Diff
4fc4521 20.50 KiB 335.95 KiB 315.45 KiB

@philipphofmann philipphofmann merged commit 654f180 into master Oct 13, 2022
@philipphofmann philipphofmann deleted the test/fix-failing-master-tests branch October 13, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants