fix: CoreData tracking entity name retrieval #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armcknight
commented
Oct 25, 2022
Comment on lines
-150
to
+151
| for (id item in entities) { | ||
| NSString *cl = NSStringFromClass([item class]); | ||
| for (NSManagedObject *item in entities) { | ||
| NSString *cl = item.entity.name; |
There was a problem hiding this comment.
This is an actual functional change that I think was a bug.
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 791123d | 1256.10 ms | 1266.68 ms | 10.58 ms |
| 202334c | 1265.41 ms | 1277.34 ms | 11.93 ms |
| e2f1150 | 1220.39 ms | 1249.94 ms | 29.55 ms |
| 5ecf9f6 | 1230.76 ms | 1232.86 ms | 2.10 ms |
| 654f180 | 1220.08 ms | 1248.76 ms | 28.67 ms |
| 4a188b8 | 1229.81 ms | 1255.96 ms | 26.15 ms |
| 7138b7d | 1243.40 ms | 1252.08 ms | 8.68 ms |
| 0fdf0b2 | 1243.92 ms | 1250.86 ms | 6.94 ms |
| 3e85a23 | 1244.94 ms | 1265.55 ms | 20.61 ms |
| 5025d2e | 1248.52 ms | 1251.72 ms | 3.20 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 791123d | 20.51 KiB | 331.81 KiB | 311.30 KiB |
| 202334c | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| e2f1150 | 20.51 KiB | 333.10 KiB | 312.59 KiB |
| 5ecf9f6 | 20.51 KiB | 332.66 KiB | 312.15 KiB |
| 654f180 | 20.50 KiB | 335.95 KiB | 315.45 KiB |
| 4a188b8 | 20.50 KiB | 337.70 KiB | 317.20 KiB |
| 7138b7d | 20.51 KiB | 331.79 KiB | 311.28 KiB |
| 0fdf0b2 | 20.51 KiB | 332.90 KiB | 312.39 KiB |
| 3e85a23 | 20.50 KiB | 339.00 KiB | 318.49 KiB |
| 5025d2e | 20.51 KiB | 331.79 KiB | 311.28 KiB |
brustolin
approved these changes
Oct 31, 2022
kevinrenskers
approved these changes
Oct 31, 2022
|
Oh interesting, I wonder if that's because there's no xcdatamodel/NSManagedObjectModel in the unit tests @brustolin ? 🤔 If that's the case and there's no actual user-facing bug right now, i'll remove the changelog entry. |
Im not sure if this is the reason. |
kevinrenskers
added a commit
that referenced
this pull request
Nov 7, 2022
* master: test: Delete empty OOMLogicTests (#2361) fix: profiling transaction timestamps (#2359) fix: profiling transaction thread IDs (#2358) test: Use flush for macOS-SPM sample (#2360) release: 7.30.0 fix: SentryCrash writing nan for invalid number (#2348) HTTP Client errors (#2308) ci: Call make for analyze (#2353) fix: CoreData tracking entity name retrieval (#2329) fix: sampled profile format backend validation errors (#2350) build(deps): bump github/codeql-action from 2.1.29 to 2.1.30 (#2351) build(deps): bump github/codeql-action from 2.1.28 to 2.1.29 (#2344) fix: Fixed flaky testTimezoneChangeNotificationBreadcrumb (#2335) # Conflicts: # Sentry.xcodeproj/project.pbxproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2328 and possible bug in CoreData tracker.
I originally noticed a system error logged for us using a non-designated initializer for an NSManagedObject subclass. Fixing that led to some test failures:
which led to me discovering that we might have only ever tracked CoreData entity transactions using "NSManagedObject" in the span descriptions instead of the actual entity names being used by developers.