Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Fix typos in OOMTracker #2431

Merged
merged 1 commit into from
Nov 22, 2022
Merged

ref: Fix typos in OOMTracker #2431

merged 1 commit into from
Nov 22, 2022

Conversation

philipphofmann
Copy link
Member

#skip-changelog

@philipphofmann philipphofmann enabled auto-merge (squash) November 22, 2022 13:45
@github-actions
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1265.57 ms 1266.76 ms 1.19 ms
Size 20.75 KiB 381.81 KiB 361.06 KiB

Baseline results on branch: 8.0.0

Startup times

Revision Plain With Sentry Diff
a9e77dc 1231.94 ms 1254.85 ms 22.91 ms
58ec104 1244.29 ms 1269.67 ms 25.39 ms
9be1db2 1219.42 ms 1245.66 ms 26.24 ms
88ac2c2 1223.04 ms 1243.12 ms 20.08 ms
d10145a 1232.65 ms 1257.55 ms 24.90 ms
7eee302 1228.73 ms 1241.94 ms 13.21 ms
dcac8ad 1238.82 ms 1247.80 ms 8.98 ms
68094b3 1214.14 ms 1255.09 ms 40.95 ms
e2cec76 1189.48 ms 1229.84 ms 40.36 ms

App size

Revision Plain With Sentry Diff
a9e77dc 20.75 KiB 379.12 KiB 358.36 KiB
58ec104 20.75 KiB 379.11 KiB 358.36 KiB
9be1db2 20.75 KiB 373.94 KiB 353.19 KiB
88ac2c2 20.75 KiB 373.61 KiB 352.86 KiB
d10145a 20.75 KiB 379.12 KiB 358.36 KiB
7eee302 20.75 KiB 374.73 KiB 353.97 KiB
dcac8ad 20.75 KiB 379.11 KiB 358.36 KiB
68094b3 20.75 KiB 373.94 KiB 353.19 KiB
e2cec76 20.75 KiB 381.81 KiB 361.06 KiB

@philipphofmann philipphofmann merged commit 4dc66f6 into 8.0.0 Nov 22, 2022
@philipphofmann philipphofmann deleted the ref/fix-typos branch November 22, 2022 15:27
kevinrenskers added a commit that referenced this pull request Nov 22, 2022
@kevinrenskers
Merge branch '8.0.0' into ref/rename-classes
5a09cc5 
* 8.0.0:
  ref: Fix typos in OOMTracker (#2431)
  ref: Make SpanProtocol.data non nullable (#2409)
  ref: add/improve logging (#2420)
  ref: bump supported OS versions (#2414)
  test: shorten some tests (#2428)
  ref: Remove `- [SentryOptions initWithDict:didFailWithError:]` (#2404)
  ref: Mark [SpanProtocol setExtraValue:forKey] as deprecated (#2413)
  typos (#2421)
  test: Disable NSDataTracker in clearTestState (#2418)
  Update CHANGELOG.md (#2415)
  feat: Properly demangle Swift class name (#2162)
  chore: Create 8.0.0 branch
  test: include Sentry changes in hash keys (#2412)
  release: 7.31.2
  fix: Crash in Client when reading integrations (#2398)
  test: tooling improvements (#2400)
  fix: Don't increase session's error count for dropped events (#2374)
  Update CHANGELOG.md (#2396)
  release: 7.31.1
  Fix: Set the correct OOM event timestamp (#2394)

# Conflicts:
#	Sentry.xcodeproj/project.pbxproj
#	SentryPrivate.podspec
#	scripts/add-sentry-to-vlc.patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinrenskers kevinrenskers kevinrenskers approved these changes

@brustolin brustolin Awaiting requested review from brustolin brustolin is a code owner

@armcknight armcknight Awaiting requested review from armcknight armcknight is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philipphofmann @kevinrenskers