add tests and move to flutter options

getsentry · Jul 24, 2023 · 3c34d27 · 3c34d27
1 parent c62e2a3
commit 3c34d27
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 10 deletions.
diff --git a/dart/lib/src/sentry_options.dart b/dart/lib/src/sentry_options.dart
@@ -300,12 +300,6 @@ class SentryOptions {
 
   List<ScopeObserver> get scopeObservers => _scopeObservers;
 
-  /// The minimum amount of time an app should be unresponsive to be classified
-  /// as an App Hanging. The actual amount may be a little longer. Avoid using
-  /// values lower than 100ms, which may cause a lot of app hangs events being
-  /// transmitted.
-  Duration appHangTimeoutInterval = Duration(seconds: 2);
-
   void addScopeObserver(ScopeObserver scopeObserver) {
     _scopeObservers.add(scopeObserver);
   }

diff --git a/flutter/example/lib/main.dart b/flutter/example/lib/main.dart
@@ -2,7 +2,6 @@
 
 import 'dart:async';
 import 'dart:convert';
-import 'dart:io' show Platform;
 
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';

diff --git a/flutter/lib/src/integrations/native_sdk_integration.dart b/flutter/lib/src/integrations/native_sdk_integration.dart
@@ -51,7 +51,8 @@ class NativeSdkIntegration implements Integration<SentryFlutterOptions> {
         'enableAppHangTracking': options.enableAppHangTracking,
         'connectionTimeoutMillis': options.connectionTimeout.inMilliseconds,
         'readTimeoutMillis': options.readTimeout.inMilliseconds,
-        'appHangTimeoutIntervalMillis': options.appHangTimeoutInterval.inMilliseconds
+        'appHangTimeoutIntervalMillis':
+            options.appHangTimeoutInterval.inMilliseconds,
       });
 
       options.sdk.addIntegration('nativeSdkIntegration');

diff --git a/flutter/lib/src/sentry_flutter_options.dart b/flutter/lib/src/sentry_flutter_options.dart
@@ -195,10 +195,17 @@ class SentryFlutterOptions extends SentryOptions {
   bool attachViewHierarchy = false;
 
   /// When enabled, the SDK tracks when the application stops responding for a
-  /// specific amount of time (default 2s).
+  /// specific amount of time.
   /// Only available on iOS and macOS.
   bool enableAppHangTracking = true;
 
+  /// The minimum amount of time an app should be unresponsive to be classified
+  /// as an App Hanging. The actual amount may be a little longer. Avoid using
+  /// values lower than 100ms, which may cause a lot of app hangs events being
+  /// transmitted.
+  /// Only available on iOS and macOS.
+  Duration appHangTimeoutInterval = Duration(seconds: 2);
+
   /// Connection timeout. This will only be synced to the Android native SDK.
   Duration connectionTimeout = Duration(seconds: 5);
 

diff --git a/flutter/test/integrations/init_native_sdk_integration_test.dart b/flutter/test/integrations/init_native_sdk_integration_test.dart
@@ -62,6 +62,7 @@ void main() {
         'enableAppHangTracking': true,
         'connectionTimeoutMillis': 5000,
         'readTimeoutMillis': 5000,
+        'appHangTimeoutIntervalMillis': 2000,
       });
     });
 
@@ -100,7 +101,8 @@ void main() {
         ..captureFailedRequests = false
         ..enableAppHangTracking = false
         ..connectionTimeout = Duration(milliseconds: 9001)
-        ..readTimeout = Duration(milliseconds: 9002);
+        ..readTimeout = Duration(milliseconds: 9002)
+        ..appHangTimeoutInterval = Duration(milliseconds: 9003);
 
       options.sdk.addIntegration('foo');
       options.sdk.addPackage('bar', '1');
@@ -143,6 +145,7 @@ void main() {
         'enableAppHangTracking': false,
         'connectionTimeoutMillis': 9001,
         'readTimeoutMillis': 9002,
+        'appHangTimeoutIntervalMillis': 9003,
       });
     });