Set snapshot to true (#2000)

* set snapshot to true * test * test the inverse * changelog --------- Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com>
getsentry · Apr 24, 2024 · 47dd159 · 47dd159
1 parent cfa25fc
commit 47dd159
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,11 @@
 
 ## Unreleased
 
+### Feature
+
+- Set snapshot to `true` when Sentry attaches a stacktrace ([#2000](https://github.com/getsentry/sentry-dart/pull/2000)) 
+  - This may change grouping
+
 ### Fixes
 
 - Timing metric aggregates metrics in the created span ([#1994](https://github.com/getsentry/sentry-dart/pull/1994))

diff --git a/dart/lib/src/sentry_exception_factory.dart b/dart/lib/src/sentry_exception_factory.dart
@@ -38,9 +38,8 @@ class SentryExceptionFactory {
     // hence we check again if stackTrace is null and if not, read the current stack trace
     // but only if attachStacktrace is enabled
     if (_options.attachStacktrace) {
-      // TODO: snapshot=true if stackTrace is null
-      // Requires a major breaking change because of grouping
       if (stackTrace == null || stackTrace == StackTrace.empty) {
+        snapshot = true;
         stackTrace = StackTrace.current;
       }
     }

diff --git a/dart/test/sentry_exception_factory_test.dart b/dart/test/sentry_exception_factory_test.dart
@@ -188,6 +188,24 @@ void main() {
 
     expect(sentryException.value, isNull);
   });
+
+  test(
+      'set snapshot to true when no stracktrace is present & attachStacktrace == true',
+      () {
+    final sentryException =
+        fixture.getSut(attachStacktrace: true).getSentryException(Object());
+
+    expect(sentryException.stackTrace!.snapshot, true);
+  });
+
+  test(
+      'set snapshot to false when no stracktrace is present & attachStacktrace == false',
+      () {
+    final sentryException =
+        fixture.getSut(attachStacktrace: false).getSentryException(Object());
+
+    expect(sentryException.stackTrace!.snapshot, true);
+  });
 }
 
 class CustomError extends Error {}
@@ -268,7 +286,8 @@ isolate_instructions: 7526344980, vm_instructions: 752633f000
 class Fixture {
   final options = SentryOptions(dsn: fakeDsn);
 
-  SentryExceptionFactory getSut() {
+  SentryExceptionFactory getSut({bool attachStacktrace = true}) {
+    options.attachStacktrace = true;
     return SentryExceptionFactory(options);
   }
 }