Revert to check & fail only approach for format & analyze

getsentry · Jul 31, 2023 · 616aa76 · 616aa76
1 parent d783424
commit 616aa76
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 28 deletions.
diff --git a/.github/workflows/analyze.yml b/.github/workflows/analyze.yml
@@ -24,7 +24,6 @@ jobs:
           access_token: ${{ github.token }}
 
   analyze:
-    name: Format, fix & analyze Code
     if: ${{ !startsWith(github.ref, 'refs/heads/release/') }}
     runs-on: ubuntu-latest
     timeout-minutes: 20
@@ -39,17 +38,8 @@ jobs:
         if: ${{ inputs.sdk == 'flutter' }}
 
       - run: ${{ inputs.sdk }} pub get
-
-      - run: dart format .
-
-      - run: dart fix --apply
-
-        # actions/checkout fetches only a single commit in a detached HEAD state. Therefore
-        # we need to pass the current branch, otherwise we can't commit the changes.
-        # GITHUB_HEAD_REF is the name of the head branch. GitHub Actions only sets this for PRs.
-      - run: ../scripts/commit-formatted-code.sh $GITHUB_HEAD_REF
-        if: env.GITHUB_HEAD_REF != null
-
+      - run: dart format --set-exit-if-changed ./
+
       - name: dart analyze
         uses: invertase/github-action-dart-analyzer@cdd8652b05bf7ed08ffce30f425436780f869f13 # pin@v1
         with:

diff --git a/scripts/commit-formatted-code.sh b/scripts/commit-formatted-code.sh