Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing props #1354

Merged
merged 6 commits into from
Mar 27, 2023
Merged

Add missing props #1354

merged 6 commits into from
Mar 27, 2023

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Mar 24, 2023

📜 Description

💡 Motivation and Context

Some props were not synced down to native SDKs and features enabled by default could not be turned off.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (89ea268) 89.96% compared to head (135a9fe) 89.96%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1354   +/-   ##
=======================================
  Coverage   89.96%   89.96%           
=======================================
  Files         176      176           
  Lines        5563     5563           
=======================================
  Hits         5005     5005           
  Misses        558      558           
Impacted Files Coverage Δ
flutter/lib/src/sentry_flutter_options.dart 100.00% <ø> (ø)
...r/lib/src/integrations/native_sdk_integration.dart 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 365.94 ms 437.76 ms 71.82 ms
Size 6.06 MiB 7.03 MiB 989.38 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
68677de 364.41 ms 415.61 ms 51.20 ms
c1bb00f 303.77 ms 371.88 ms 68.11 ms
5603ab2 309.84 ms 345.20 ms 35.36 ms
633cf2e 289.36 ms 340.38 ms 51.02 ms
9c5aec6 287.33 ms 320.94 ms 33.61 ms
333903e 332.76 ms 406.86 ms 74.10 ms
1edf30e 334.00 ms 378.35 ms 44.35 ms
fe4aa56 356.06 ms 428.67 ms 72.61 ms
d301b11 337.96 ms 395.04 ms 57.08 ms
6e083bb 327.96 ms 381.39 ms 53.43 ms

App size

Revision Plain With Sentry Diff
68677de 6.06 MiB 7.10 MiB 1.04 MiB
c1bb00f 6.06 MiB 7.09 MiB 1.03 MiB
5603ab2 5.94 MiB 6.95 MiB 1.01 MiB
633cf2e 5.94 MiB 6.92 MiB 1001.53 KiB
9c5aec6 5.94 MiB 6.92 MiB 1001.61 KiB
333903e 6.06 MiB 7.10 MiB 1.04 MiB
1edf30e 5.94 MiB 6.96 MiB 1.02 MiB
fe4aa56 6.06 MiB 7.10 MiB 1.04 MiB
d301b11 6.06 MiB 7.09 MiB 1.03 MiB
6e083bb 5.94 MiB 6.97 MiB 1.03 MiB

@github-actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1291.20 ms 1315.47 ms 24.27 ms
Size 8.10 MiB 9.16 MiB 1.06 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ecb4003 1266.94 ms 1290.24 ms 23.31 ms
6957bfd 1283.80 ms 1289.00 ms 5.20 ms
5aab4c5 1247.08 ms 1271.17 ms 24.09 ms
f1314d5 1246.46 ms 1270.92 ms 24.46 ms
fe4aa56 1248.82 ms 1261.35 ms 12.53 ms
6325c3b 1266.52 ms 1291.06 ms 24.54 ms
ef2f368 1259.12 ms 1277.04 ms 17.92 ms
379d7a8 1267.65 ms 1288.39 ms 20.74 ms
08a7b4f 1277.10 ms 1303.37 ms 26.27 ms
7f2b01d 1253.92 ms 1266.70 ms 12.78 ms

App size

Revision Plain With Sentry Diff
ecb4003 8.09 MiB 9.07 MiB 1000.82 KiB
6957bfd 8.15 MiB 9.15 MiB 1020.71 KiB
5aab4c5 8.10 MiB 9.16 MiB 1.07 MiB
f1314d5 8.10 MiB 9.08 MiB 1004.30 KiB
fe4aa56 8.10 MiB 9.08 MiB 1004.36 KiB
6325c3b 8.16 MiB 9.17 MiB 1.01 MiB
ef2f368 8.15 MiB 9.10 MiB 965.24 KiB
379d7a8 8.16 MiB 9.16 MiB 1.00 MiB
08a7b4f 8.16 MiB 9.16 MiB 1.01 MiB
7f2b01d 8.16 MiB 9.16 MiB 1.00 MiB

@marandaneto marandaneto marked this pull request as ready for review March 24, 2023 14:59
@marandaneto marandaneto merged commit e2d89fc into main Mar 27, 2023
@marandaneto marandaneto deleted the chore/add-missing-props branch March 27, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants