Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github pages #1590

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Fix github pages #1590

merged 1 commit into from
Aug 9, 2023

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Aug 8, 2023

📜 Description

Pass missing baseHref
https://docs.flutter.dev/ui/navigation/url-strategies#hosting-a-flutter-app-at-a-non-root-location
#skip-changelog

💡 Motivation

Screenshot 2023-08-08 at 14 25 11 and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.87% ⚠️

Comparison is base (d783424) 91.19% compared to head (23f26b4) 90.32%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1590      +/-   ##
==========================================
- Coverage   91.19%   90.32%   -0.87%     
==========================================
  Files          61      181     +120     
  Lines        2078     5861    +3783     
==========================================
+ Hits         1895     5294    +3399     
- Misses        183      567     +384     

see 120 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marandaneto marandaneto merged commit f370d52 into main Aug 9, 2023
84 of 87 checks passed
@marandaneto marandaneto deleted the fix/flutter-web-gh-pages branch August 9, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants