Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows package_info_plus v8 #2010

Merged
merged 6 commits into from
Apr 25, 2024

Conversation

AlexV525
Copy link
Contributor

@AlexV525 AlexV525 commented Apr 23, 2024

📜 Description

Update the version constraint of package_info_plus dependency from >=1.0.0 <8.0.0 to >=1.0.0.

💡 Motivation and Context

A major version was released with the corresponding package, and sentry_flutter doesn't allow it to be resolved.

💚 How did you test it?

N/A

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

@AlexV525 AlexV525 marked this pull request as ready for review April 23, 2024 13:48
@AlexV525 AlexV525 changed the title Allows package_info_plus v9 Allows package_info_plus v8 Apr 23, 2024
@kuhnroyal
Copy link
Contributor

They seem to have a daily major release schedule for this plugin :D

@AlexV525
Copy link
Contributor Author

They seem to have a daily major release schedule for this plugin :D

Oh that's cool! So I can close the request then?

@ueman
Copy link
Collaborator

ueman commented Apr 23, 2024

No, kuhnroyal means a daily major change for package_info_plus.
On a kinda related note, package_info_plus didn't have a change in API for the functionality Sentry requires, so maybe at this point it can be package_info_plus: any?

@AlexV525
Copy link
Contributor Author

No, kuhnroyal means a daily major change for package_info_plus. On a kinda related note, package_info_plus didn't have a change in API for the functionality Sentry requires, so maybe at this point it can be package_info_plus: any?

any should lead to a pub score decrement IIRC. But >=1.0.0 might work, I'm not sure though. :)

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.20%. Comparing base (1ac008b) to head (613f225).
Report is 86 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2010      +/-   ##
==========================================
+ Coverage   88.57%   92.20%   +3.62%     
==========================================
  Files         207       57     -150     
  Lines        6897     1859    -5038     
==========================================
- Hits         6109     1714    -4395     
+ Misses        788      145     -643     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@buenaflor buenaflor merged commit 0bed04d into getsentry:main Apr 25, 2024
40 checks passed
@AlexV525 AlexV525 deleted the feat/package_info_plus_v9 branch April 25, 2024 11:52
@Imgkl
Copy link

Imgkl commented Apr 25, 2024

@buenaflor Any rough timeline on when this will be made live on pub.dev? We are unable to use certain packages because of this.

@buenaflor
Copy link
Contributor

@Imgkl I'll see to it that we'll release it tomorrow the latest

meanwhile you can use

dependency_overrides:
  package_info_plus: ^8.0.0

@Imgkl
Copy link

Imgkl commented Apr 29, 2024

@buenaflor just checking in. Any updates?

@buenaflor
Copy link
Contributor

hey sorry for the delay, we are awaiting a Sentry Cocoa SDK release that we will ship along because of apple's new privacy guidelines

@buenaflor
Copy link
Contributor

fyi I'll start the release process when the cocoa version bump is merged into the flutter sdk

(getsentry/publish#3763)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants