feat(performance): report total frames, frame delay, slow & frozen frames

CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+### Features
+
+- Capture total frames, frame delay, slow & frozen frames and attach to spans ([#2106](https://github.com/getsentry/sentry-dart/pull/2106))
 ### Dependencies
 
 - Bump Cocoa SDK from v8.29.0 to v8.29.1 ([#2109](https://github.com/getsentry/sentry-dart/pull/2109))

dart/lib/sentry.dart

@@ -30,6 +30,7 @@ export 'src/http_client/sentry_http_client_error.dart';
 export 'src/sentry_attachment/sentry_attachment.dart';
 export 'src/sentry_user_feedback.dart';
 export 'src/utils/tracing_utils.dart';
+export 'src/performance_collector.dart';
 // tracing
 export 'src/tracing.dart';
 export 'src/hint.dart';

dart/lib/src/performance_collector.dart

@@ -0,0 +1,13 @@
+import '../sentry.dart';
+
+abstract class PerformanceCollector {}
+
+/// Used for collecting continuous data about vitals (slow, frozen frames, etc.)
+/// during a transaction/span.
+abstract class PerformanceContinuousCollector extends PerformanceCollector {
+  Future<void> onSpanStarted(ISentrySpan span);
+
+  Future<void> onSpanFinished(ISentrySpan span, DateTime endTimestamp);
+
+  void clear();
+}

dart/lib/src/protocol/sentry_span.dart

@@ -1,12 +1,11 @@
 import 'dart:async';
 
-import '../hub.dart';
+import 'package:meta/meta.dart';
+
+import '../../sentry.dart';
 import '../metrics/local_metrics_aggregator.dart';
-import '../protocol.dart';
 
 import '../sentry_tracer.dart';
-import '../tracing.dart';
-import '../utils.dart';
 
 typedef OnFinishedCallback = Future<void> Function({DateTime? endTimestamp});
 
@@ -17,7 +16,15 @@
   late final DateTime _startTimestamp;
   final Hub _hub;
 
+  bool _isRootSpan = false;
+
+  bool get isRootSpan => _isRootSpan;
+
+  @internal
+  SentryTracer get tracer => _tracer;
+
   final SentryTracer _tracer;
+
   final Map<String, dynamic> _data = {};
   dynamic _throwable;
 
@@ -36,13 +43,15 @@
     DateTime? startTimestamp,
     this.samplingDecision,
     OnFinishedCallback? finishedCallback,
+    isRootSpan = false,
   }) {
     _startTimestamp = startTimestamp?.toUtc() ?? _hub.options.clock();
     _finishedCallback = finishedCallback;
     _origin = _context.origin;
     _localMetricsAggregator = _hub.options.enableSpanLocalMetricAggregation
         ? LocalMetricsAggregator()
         : null;
+    _isRootSpan = isRootSpan;
   }
 
   @override
@@ -56,17 +65,27 @@
     }
 
     if (endTimestamp == null) {
-      _endTimestamp = _hub.options.clock();
+      endTimestamp = _hub.options.clock();
     } else if (endTimestamp.isBefore(_startTimestamp)) {
       _hub.options.logger(
         SentryLevel.warning,
         'End timestamp ($endTimestamp) cannot be before start timestamp ($_startTimestamp)',
       );
-      _endTimestamp = _hub.options.clock();
+      endTimestamp = _hub.options.clock();
     } else {
-      _endTimestamp = endTimestamp.toUtc();
+      endTimestamp = endTimestamp.toUtc();
     }
 
+    for (final collector in _hub.options.performanceCollectors) {
+      if (collector is PerformanceContinuousCollector) {
+        await collector.onSpanFinished(this, endTimestamp);
+      }
+    }
+
+    // The finished flag depends on the _endTimestamp
+    // If we set this earlier then finished is true and then we cannot use setData etc...
+    _endTimestamp = endTimestamp;
+
     // associate error
     if (_throwable != null) {
       _hub.setSpanContext(_throwable, this, _tracer.name);

dart/lib/src/sentry_options.dart

@@ -501,6 +501,14 @@
     return tracesSampleRate != null || tracesSampler != null;
   }
 
+  List<PerformanceCollector> get performanceCollectors =>
+      _performanceCollectors;
+  final List<PerformanceCollector> _performanceCollectors = [];
+
+  void addPerformanceCollector(PerformanceCollector collector) {
+    _performanceCollectors.add(collector);
+  }
+
   @internal
   late SentryExceptionFactory exceptionFactory = SentryExceptionFactory(this);
 

dart/lib/src/sentry_tracer.dart

@@ -69,6 +69,7 @@
       _hub,
       samplingDecision: transactionContext.samplingDecision,
       startTimestamp: startTimestamp,
+      isRootSpan: true,
     );
     _waitForChildren = waitForChildren;
     _autoFinishAfter = autoFinishAfter;
@@ -80,6 +81,12 @@
         SentryTransactionNameSource.custom;
     _trimEnd = trimEnd;
     _onFinish = onFinish;
+
+    for (final collector in _hub.options.performanceCollectors) {
+      if (collector is PerformanceContinuousCollector) {
+        collector.onSpanStarted(_rootSpan);
+      }
+    }
   }
 
   @override
@@ -256,6 +263,12 @@
 
     _children.add(child);
 
+    for (final collector in _hub.options.performanceCollectors) {
+      if (collector is PerformanceContinuousCollector) {
+        collector.onSpanStarted(child);
+      }
+    }
+
     return child;
   }
 

flutter/android/src/main/kotlin/io/sentry/flutter/SentryFlutterPlugin.kt

@@ -2,6 +2,7 @@ package io.sentry.flutter
 
 import android.app.Activity
 import android.content.Context
+import android.os.Build
 import android.util.Log
 import io.flutter.embedding.engine.plugins.FlutterPlugin
 import io.flutter.embedding.engine.plugins.activity.ActivityAware
@@ -72,6 +73,7 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
       "setTag" -> setTag(call.argument("key"), call.argument("value"), result)
       "removeTag" -> removeTag(call.argument("key"), result)
       "loadContexts" -> loadContexts(result)
+      "displayRefreshRate" -> displayRefreshRate(result)
       else -> result.notImplemented()
     }
   }
@@ -179,6 +181,29 @@ class SentryFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
     }
   }
 
+  private fun displayRefreshRate(result: Result) {
+    var refreshRate: Int? = null
+
+    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.R) {
+      val display = activity?.get()?.display
+      if (display != null) {
+        refreshRate = display.refreshRate.toInt()
+      }
+    } else {
+      val display =
+        activity
+          ?.get()
+          ?.window
+          ?.windowManager
+          ?.defaultDisplay
+      if (display != null) {
+        refreshRate = display.refreshRate.toInt()
+      }
+    }
+
+    result.success(refreshRate)
+  }
+
   private fun TimeSpan.addToMap(map: MutableMap<String, Any?>) {
     if (startTimestamp == null) return
 

flutter/ios/Classes/SentryFlutterPluginApple.swift

@@ -5,6 +5,7 @@ import UIKit
 #elseif os(macOS)
 import FlutterMacOS
 import AppKit
+import CoreVideo
 #endif
 
 // swiftlint:disable file_length function_body_length
@@ -164,6 +165,9 @@ public class SentryFlutterPluginApple: NSObject, FlutterPlugin {
             collectProfile(call, result)
         #endif
 
+        case "displayRefreshRate":
+            displayRefreshRate(result)
+
         default:
             result(FlutterMethodNotImplemented)
         }
@@ -651,6 +655,58 @@ public class SentryFlutterPluginApple: NSObject, FlutterPlugin {
         PrivateSentrySDKOnly.discardProfiler(forTrace: SentryId(uuidString: traceId))
         result(nil)
     }
+
+    #if os(iOS)
+    // Taken from the Flutter engine:
+    // https://github.com/flutter/engine/blob/main/shell/platform/darwin/ios/framework/Source/vsync_waiter_ios.mm#L150
+    private func displayRefreshRate(_ result: @escaping FlutterResult) {
+        let displayLink = CADisplayLink(target: self, selector: #selector(onDisplayLink(_:)))
+        displayLink.add(to: .main, forMode: .common)
+        displayLink.isPaused = true
+
+        let preferredFPS = displayLink.preferredFramesPerSecond
+        displayLink.invalidate()
+
+        if preferredFPS != 0 {
+            result(preferredFPS)
+            return
+        }
+
+        if #available(iOS 13.0, *) {
+            guard let windowScene = UIApplication.shared.windows.first?.windowScene else {
+                result(nil)
+                return
+            }
+            result(windowScene.screen.maximumFramesPerSecond)
+        } else {
+            result(UIScreen.main.maximumFramesPerSecond)
+        }
+    }
+
+    @objc private func onDisplayLink(_ displayLink: CADisplayLink) {
+        // No-op
+    }
+    #elseif os(macOS)
+    private func displayRefreshRate(_ result: @escaping FlutterResult) {
+        let displayID: CGDirectDisplayID = CGMainDisplayID()
+        var displayLink: CVDisplayLink?
+
+        if CVDisplayLinkCreateWithCGDisplay(displayID, &displayLink) != kCVReturnSuccess {
+            result(nil)
+            return
+        }
+
+        guard let link = displayLink else {
+            result(nil)
+            return
+        }
+
+        let period = CVDisplayLinkGetNominalOutputVideoRefreshPeriod(link)
+        let refreshRate = Int(round(Double(period.timeScale) / Double(period.timeValue)))
+
+        result(refreshRate)
+    }
+    #endif
 }
 
 // swiftlint:enable function_body_length

flutter/lib/src/frame_callback_handler.dart

@@ -1,7 +1,11 @@
+import 'package:flutter/cupertino.dart';
 import 'package:flutter/scheduler.dart';
 
 abstract class FrameCallbackHandler {
   void addPostFrameCallback(FrameCallback callback);
+  void addPersistentFrameCallback(FrameCallback callback);
+  Future<void> get endOfFrame;
+  bool get hasScheduledFrame;
 }
 
 class DefaultFrameCallbackHandler implements FrameCallbackHandler {
@@ -12,4 +16,21 @@
       SchedulerBinding.instance.addPostFrameCallback(callback);
     } catch (_) {}
   }
+
+  @override
+  void addPersistentFrameCallback(FrameCallback callback) {
+    try {
+      WidgetsBinding.instance.addPersistentFrameCallback(callback);
+    } catch (_) {}
+  }
+
+  @override
+  Future<void> get endOfFrame async {
+    try {
+      await WidgetsBinding.instance.endOfFrame;
+    } catch (_) {}
+  }
+
+  @override
+  bool get hasScheduledFrame => WidgetsBinding.instance.hasScheduledFrame;
 }

flutter/lib/src/native/sentry_native_binding.dart

@@ -46,6 +46,8 @@ abstract class SentryNativeBinding {
 
   Future<void> discardProfiler(SentryId traceId);
 
+  Future<int?> displayRefreshRate();
+
   Future<Map<String, dynamic>?> collectProfile(
       SentryId traceId, int startTimeNs, int endTimeNs);
 

flutter/lib/src/native/sentry_native_channel.dart

@@ -178,4 +178,8 @@
             .map(DebugImage.fromJson)
             .toList();
       });
+
+  @override
+  Future<int?> displayRefreshRate() =>
+      _channel.invokeMethod('displayRefreshRate');
 }

flutter/lib/src/sentry_flutter.dart

@@ -3,6 +3,7 @@ import 'dart:ui';
 
 import 'package:flutter/widgets.dart';
 import 'package:meta/meta.dart';
+import 'span_frame_metrics_collector.dart';
 import '../sentry_flutter.dart';
 import 'event_processor/android_platform_exception_event_processor.dart';
 import 'event_processor/flutter_exception_event_processor.dart';
@@ -135,6 +136,8 @@ mixin SentryFlutter {
 
     options.addEventProcessor(PlatformExceptionEventProcessor());
 
+    options.addPerformanceCollector(SpanFrameMetricsCollector(options));
+
     _setSdk(options);
   }
 

flutter/lib/src/sentry_flutter_options.dart

@@ -232,6 +232,20 @@ class SentryFlutterOptions extends SentryOptions {
   /// Read timeout. This will only be synced to the Android native SDK.
   Duration readTimeout = Duration(seconds: 5);
 
+  /// Enable or disable Frames Tracking, which is used to report frame information
+  /// for every [ISentrySpan].
+  ///
+  /// When enabled, the following metrics are reported for each span:
+  /// - Slow frames: The number of frames that exceeded a specified threshold for frame duration.
+  /// - Frozen frames: The number of frames that took an unusually long time to render, indicating a potential freeze or hang.
+  /// - Total frames count: The total number of frames rendered during the span.
+  /// - Frames delay: The delayed frame render duration of all frames.
+
+  /// Read more about frames tracking here: https://develop.sentry.dev/sdk/performance/frames-delay/
+  ///
+  /// Defaults to `true`
+  bool enableFramesTracking = true;
+
   /// By using this, you are disabling native [Breadcrumb] tracking and instead
   /// you are just tracking [Breadcrumb]s which result from events available
   /// in the current Flutter environment.