capture response body for failed requests and if tracing is enabled in SentryHttpClient #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- capture response body for failed requests and if tracing is enabled in SentryHttpClient ([#2293](https://github.com/getsentry/sentry-dart/pull/2293))If none of the above apply, you can opt out of this check by adding |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2293 +/- ##
==========================================
- Coverage 88.35% 86.93% -1.42%
==========================================
Files 247 104 -143
Lines 8578 3713 -4865
==========================================
- Hits 7579 3228 -4351
+ Misses 999 485 -514 ☔ View full report in Codecov by Sentry. |
iOS Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d8f5abb | 1237.73 ms | 1259.13 ms | 21.39 ms |
| f275487 | 1291.65 ms | 1339.92 ms | 48.26 ms |
| fcd1ee4 | 1247.18 ms | 1251.35 ms | 4.16 ms |
| f7f46dc | 1285.82 ms | 1315.06 ms | 29.24 ms |
| ba9c106 | 1241.76 ms | 1265.15 ms | 23.40 ms |
| 77db8d4 | 1228.47 ms | 1248.80 ms | 20.33 ms |
| ccc09e4 | 1254.74 ms | 1277.08 ms | 22.34 ms |
| dd933d4 | 1238.73 ms | 1252.43 ms | 13.70 ms |
| d883d62 | 1221.39 ms | 1230.18 ms | 8.80 ms |
| 6034b0a | 1244.89 ms | 1270.22 ms | 25.33 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d8f5abb | 8.33 MiB | 9.40 MiB | 1.07 MiB |
| f275487 | 8.32 MiB | 9.38 MiB | 1.05 MiB |
| fcd1ee4 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
| f7f46dc | 8.10 MiB | 9.17 MiB | 1.08 MiB |
| ba9c106 | 8.32 MiB | 9.38 MiB | 1.06 MiB |
| 77db8d4 | 8.38 MiB | 9.73 MiB | 1.35 MiB |
| ccc09e4 | 8.16 MiB | 9.16 MiB | 1.01 MiB |
| dd933d4 | 8.33 MiB | 9.64 MiB | 1.31 MiB |
| d883d62 | 8.29 MiB | 9.36 MiB | 1.07 MiB |
| 6034b0a | 8.33 MiB | 9.40 MiB | 1.07 MiB |
buenaflor
reviewed
Sep 18, 2024
Comment on lines
+282
to
283
| "All Request and Responses are now logged, if `sendDefaultPii` is `true` and `maxRequestBodySize` and `maxResponseBodySize` conditions are met.") | ||
| bool captureFailedRequests = true; |
There was a problem hiding this comment.
let's rethink this, I don't think deprecating this flag is the right way to go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
If
sendDefaultPiiis enabled andmaxResponseBodySizeis bigger than the responseBodySize, the body is logged in sentry.💡 Motivation and Context
close #2220
💚 How did you test it?
📝 Checklist
sendDefaultPiiis enabled🔮 Next steps