-
-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom replay masking rules #2324
base: main
Are you sure you want to change the base?
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- custom replay masking rules ([#2324](https://github.com/getsentry/sentry-dart/pull/2324)) If none of the above apply, you can opt out of this check by adding |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2324 +/- ##
==========================================
+ Coverage 88.07% 90.81% +2.73%
==========================================
Files 247 74 -173
Lines 8607 2438 -6169
==========================================
- Hits 7581 2214 -5367
+ Misses 1026 224 -802 ☔ View full report in Codecov by Sentry. |
Android Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8f88a49 | 364.98 ms | 413.78 ms | 48.80 ms |
5e8d2b3 | 342.17 ms | 375.83 ms | 33.66 ms |
2d3b03d | 309.53 ms | 353.40 ms | 43.87 ms |
c73ab67 | 353.82 ms | 408.71 ms | 54.90 ms |
5baa201 | 389.26 ms | 462.83 ms | 73.57 ms |
5f2f77b | 429.06 ms | 507.74 ms | 78.68 ms |
2e1e4ae | 413.34 ms | 509.24 ms | 95.90 ms |
72eeb80 | 421.38 ms | 520.81 ms | 99.44 ms |
f770c4c | 385.88 ms | 449.86 ms | 63.98 ms |
f2db4ec | 372.46 ms | 469.72 ms | 97.26 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
8f88a49 | 6.34 MiB | 7.30 MiB | 979.60 KiB |
5e8d2b3 | 6.15 MiB | 7.13 MiB | 1000.11 KiB |
2d3b03d | 6.06 MiB | 7.09 MiB | 1.03 MiB |
c73ab67 | 6.15 MiB | 7.13 MiB | 999.97 KiB |
5baa201 | 6.35 MiB | 7.33 MiB | 1005.56 KiB |
5f2f77b | 6.35 MiB | 7.40 MiB | 1.05 MiB |
2e1e4ae | 6.35 MiB | 7.42 MiB | 1.06 MiB |
72eeb80 | 6.35 MiB | 7.42 MiB | 1.06 MiB |
f770c4c | 6.33 MiB | 7.26 MiB | 950.37 KiB |
f2db4ec | 6.06 MiB | 7.03 MiB | 990.27 KiB |
iOS Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
039058a | 1227.90 ms | 1256.23 ms | 28.34 ms |
691aa3b | 1265.57 ms | 1282.13 ms | 16.55 ms |
8e133ad | 1268.19 ms | 1277.37 ms | 9.18 ms |
5aa047a | 1236.57 ms | 1241.02 ms | 4.45 ms |
d5f600b | 1220.79 ms | 1232.93 ms | 12.14 ms |
7f14ddd | 1247.36 ms | 1269.89 ms | 22.53 ms |
c732386 | 1233.20 ms | 1252.08 ms | 18.88 ms |
d5696bf | 1232.96 ms | 1254.50 ms | 21.54 ms |
014c3ea | 1298.73 ms | 1351.24 ms | 52.51 ms |
af2d175 | 1280.37 ms | 1282.24 ms | 1.88 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
039058a | 8.38 MiB | 9.71 MiB | 1.34 MiB |
691aa3b | 8.16 MiB | 9.17 MiB | 1.01 MiB |
8e133ad | 8.10 MiB | 9.16 MiB | 1.07 MiB |
5aa047a | 8.29 MiB | 9.39 MiB | 1.10 MiB |
d5f600b | 8.32 MiB | 9.38 MiB | 1.05 MiB |
7f14ddd | 8.33 MiB | 9.64 MiB | 1.31 MiB |
c732386 | 8.28 MiB | 9.33 MiB | 1.05 MiB |
d5696bf | 8.38 MiB | 9.73 MiB | 1.35 MiB |
014c3ea | 8.33 MiB | 9.39 MiB | 1.06 MiB |
af2d175 | 8.15 MiB | 9.12 MiB | 986.22 KiB |
Previous results on branch: feat/replay-custom-redact
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e2589f5 | 1251.92 ms | 1276.73 ms | 24.81 ms |
ec669f4 | 1238.29 ms | 1259.86 ms | 21.57 ms |
f6fbf8a | 1259.68 ms | 1285.17 ms | 25.49 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e2589f5 | 8.38 MiB | 9.74 MiB | 1.36 MiB |
ec669f4 | 8.38 MiB | 9.74 MiB | 1.36 MiB |
f6fbf8a | 8.38 MiB | 9.74 MiB | 1.36 MiB |
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps