unity: programmatic configuration changes #5738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vaind is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lizokm
reviewed
Nov 9, 2022
Comment on lines
21
to
32
| * `ConfigureAtBuild()` is executed by the Unity Editor during app build. | ||
| Changes you make here affect current build and also allow you to alter native platform build-time settings (Android, iOS, macOS). | ||
|
|
||
| * `ConfigureAtRuntime()` is executed on each app startup, right before the managed Sentry SDK is initialized (except for Android, iOS and macOS native layers which are already set-up by that time). | ||
| This can be used, for example, to implement your own filtering of events using the [BeforeSend](/platforms/unity/configuration/filtering/#using-platformidentifier-namebefore-send-) callback (note: this callback only runs for events coming from C# scripts). | ||
|
|
||
| <Note> | ||
|
|
||
| Not all options are used on all platforms, and some may need to be changed at build-time, other at runtime. | ||
| Usually, it's safe for both functions to run the same code, unless you know some options should only be set in one or the other. | ||
|
|
||
| </Note> |
There was a problem hiding this comment.
Suggested change
| * `ConfigureAtBuild()` is executed by the Unity Editor during app build. | |
| Changes you make here affect current build and also allow you to alter native platform build-time settings (Android, iOS, macOS). | |
| * `ConfigureAtRuntime()` is executed on each app startup, right before the managed Sentry SDK is initialized (except for Android, iOS and macOS native layers which are already set-up by that time). | |
| This can be used, for example, to implement your own filtering of events using the [BeforeSend](/platforms/unity/configuration/filtering/#using-platformidentifier-namebefore-send-) callback (note: this callback only runs for events coming from C# scripts). | |
| <Note> | |
| Not all options are used on all platforms, and some may need to be changed at build-time, other at runtime. | |
| Usually, it's safe for both functions to run the same code, unless you know some options should only be set in one or the other. | |
| </Note> | |
| * `ConfigureAtBuild()` is executed by the Unity editor during app build. | |
| Changes you make here affect the current build and also allow you to alter native platform build-time settings (Android, iOS, macOS). | |
| * `ConfigureAtRuntime()` is executed on each app startup, right before the managed Sentry SDK is initialized (except for Android, iOS, and macOS native layers, which are already set up by that time). | |
| An example of how this can be used is for implementing your own filtering of events using the [BeforeSend](/platforms/unity/configuration/filtering/#using-platformidentifier-namebefore-send-) callback. (This callback only runs for events coming from C# scripts.) | |
| <Note> | |
| Not all options can be used on all platforms. Some may need to be changed at build-time, others at runtime. | |
| In most cases it's safe for both functions to run the same code. | |
| </Note> |
There was a problem hiding this comment.
I've accepted the suggestion manually because there were other changes made to the docs (due to functionality changes in the respective SDK PR).
As for Unity Editor vs Unity editor, I've kept uppercases as that is the full name of the IDE
bitsandfoxes
approved these changes
Nov 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs update for getsentry/sentry-unity#1046