Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinUI guidance update #8602

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Conversation

jamescrosswell
Copy link
Collaborator

Pre-merge checklist

If you work at Sentry, you're able to merge your own PR without review, but please don't unless there's a good reason.

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs
  • PR was reviewed and approved by a member of the Sentry docs team

Description of changes

Integrating user feedback regarding the new WinUI documentation from getsentry/sentry-dotnet#2778 (comment)

@jamescrosswell jamescrosswell requested a review from a team as a code owner November 28, 2023 20:49
Copy link

vercel bot commented Nov 28, 2023

@jamescrosswell is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 9:02pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs-next ⬜️ Ignored (Inspect) Visit Preview Nov 30, 2023 9:02pm

@bruno-garcia
Copy link
Member

@jamescrosswell there's a conflict

Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/platforms/dotnet/guides/winui/index.mdx Outdated Show resolved Hide resolved
src/platforms/dotnet/guides/winui/index.mdx Outdated Show resolved Hide resolved
jamescrosswell and others added 2 commits November 30, 2023 20:21
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
Co-authored-by: Shana Matthews <shana.l.matthews@gmail.com>
@bruno-garcia bruno-garcia merged commit 63242df into getsentry:master Dec 1, 2023
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants