make SentryDiagnosticSubscriber._disposableListeners threadsafe (#1506)

getsentry · Mar 1, 2022 · 2b212d0 · 2b212d0
1 parent b9095d4
commit 2b212d0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,10 @@
 ### Features
 
 - Expose ConfigureAppFrame as a public static function. ([#1493](https://github.com/getsentry/sentry-dotnet/pull/1493))
+
+### Fixes
+
+- Make `SentryDiagnosticSubscriber._disposableListeners` thread safe ([#1506](https://github.com/getsentry/sentry-dotnet/pull/1506))
 
 ## 3.14.1
 

diff --git a/src/Sentry.DiagnosticSource/Internals/DiagnosticSource/SentryDiagnosticSubscriber.cs b/src/Sentry.DiagnosticSource/Internals/DiagnosticSource/SentryDiagnosticSubscriber.cs
@@ -1,5 +1,5 @@
 using System;
-using System.Collections.Generic;
+using System.Collections.Concurrent;
 using System.Diagnostics;
 using Sentry.Extensibility;
 
@@ -12,7 +12,7 @@ internal class SentryDiagnosticSubscriber : IObserver<DiagnosticListener>, IDisp
     {
         private SentryEFCoreListener? _efInterceptor { get; set; }
         private SentrySqlListener? _sqlListener { get; set; }
-        private List<IDisposable> _disposableListeners = new();
+        private ConcurrentBag<IDisposable> _disposableListeners = new();
         private IHub _hub { get; }
         private SentryOptions _options { get; }